Remove and ignore .node-version file#14143
Merged
fisker merged 2 commits intoprettier:mainfrom Jan 10, 2023
Merged
Conversation
1 task
rattrayalex
approved these changes
Jan 9, 2023
Collaborator
There was a problem hiding this comment.
Ah shoot, so sorry if I added that on accident! Thank you for fixing!
Yes, I would suggest .gitignore instead since some people may need to add .node-version to contribute and it's easy to forget to remove it.
But, it's not a big deal, and just deleting it is fine too :) so approving.
.node-version file.node-version file
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's added in #13952, I don't think we want add this to the repo. @rattrayalex Should I add it to
.gitignore?Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨