Add HAS_WEAKREF to array, deque, _grouper; remove expectedFailure markers

youknowone · youknowone · commit c99a5ae72f26 · 2026-03-04T01:39:50.000+09:00
- Add HAS_WEAKREF to PyArray and PyDeque (matches CPython)
- Add HAS_WEAKREF to PyItertoolsGrouper (internal use by groupby)
- Remove 6 expectedFailure markers from test_dataclasses for weakref/slots
  tests that now pass
diff --git a/Lib/test/test_dataclasses/__init__.py b/Lib/test/test_dataclasses/__init__.py
@@ -3672,7 +3672,6 @@ class A:
         self.assertEqual(obj.a, 'a')
         self.assertEqual(obj.b, 'b')
 
-    @unittest.expectedFailure  # TODO: RUSTPYTHON
     def test_slots_no_weakref(self):
         @dataclass(slots=True)
         class A:
@@ -3687,7 +3686,6 @@ class A:
         with self.assertRaises(AttributeError):
             a.__weakref__
 
-    @unittest.expectedFailure  # TODO: RUSTPYTHON
     def test_slots_weakref(self):
         @dataclass(slots=True, weakref_slot=True)
         class A:
@@ -3748,7 +3746,6 @@ def test_weakref_slot_make_dataclass(self):
                                     "weakref_slot is True but slots is False"):
             B = make_dataclass('B', [('a', int),], weakref_slot=True)
 
-    @unittest.expectedFailure  # TODO: RUSTPYTHON
     def test_weakref_slot_subclass_weakref_slot(self):
         @dataclass(slots=True, weakref_slot=True)
         class Base:
@@ -3767,7 +3764,6 @@ class A(Base):
         a_ref = weakref.ref(a)
         self.assertIs(a.__weakref__, a_ref)
 
-    @unittest.expectedFailure  # TODO: RUSTPYTHON
     def test_weakref_slot_subclass_no_weakref_slot(self):
         @dataclass(slots=True, weakref_slot=True)
         class Base:
@@ -3785,7 +3781,6 @@ class A(Base):
         a_ref = weakref.ref(a)
         self.assertIs(a.__weakref__, a_ref)
 
-    @unittest.expectedFailure  # TODO: RUSTPYTHON
     def test_weakref_slot_normal_base_weakref_slot(self):
         class Base:
             __slots__ = ('__weakref__',)
@@ -3830,7 +3825,6 @@ class B[T2]:
         self.assertTrue(B.__weakref__)
         B()
 
-    @unittest.expectedFailure  # TODO: RUSTPYTHON
     def test_dataclass_derived_generic_from_base(self):
         T = typing.TypeVar('T')
 
diff --git a/crates/stdlib/src/array.rs b/crates/stdlib/src/array.rs
@@ -698,7 +698,7 @@ mod array {
     }
 
     #[pyclass(
-        flags(BASETYPE),
+        flags(BASETYPE, HAS_WEAKREF),
         with(
             Comparable,
             AsBuffer,
diff --git a/crates/vm/src/stdlib/collections.rs b/crates/vm/src/stdlib/collections.rs
@@ -56,7 +56,7 @@ mod _collections {
     }
 
     #[pyclass(
-        flags(BASETYPE),
+        flags(BASETYPE, HAS_WEAKREF),
         with(
             Constructor,
             Initializer,
diff --git a/crates/vm/src/stdlib/itertools.rs b/crates/vm/src/stdlib/itertools.rs
@@ -667,7 +667,7 @@ mod decl {
         groupby: PyRef<PyItertoolsGroupBy>,
     }
 
-    #[pyclass(with(IterNext, Iterable))]
+    #[pyclass(with(IterNext, Iterable), flags(HAS_WEAKREF))]
     impl PyItertoolsGrouper {}
 
     impl SelfIter for PyItertoolsGrouper {}

Original file line number	Diff line number	Diff line change
`@@ -698,7 +698,7 @@ mod array {`
`698`	`698`	`}`
`699`	`699`
`700`	`700`	`#[pyclass(`
`701`		`- flags(BASETYPE),`
	`701`	`+ flags(BASETYPE, HAS_WEAKREF),`
`702`	`702`	`with(`
`703`	`703`	`Comparable,`
`704`	`704`	`AsBuffer,`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ mod _collections {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`#[pyclass(`
`59`		`- flags(BASETYPE),`
	`59`	`+ flags(BASETYPE, HAS_WEAKREF),`
`60`	`60`	`with(`
`61`	`61`	`Constructor,`
`62`	`62`	`Initializer,`
Original file line number	Diff line number	Diff line change
`@@ -667,7 +667,7 @@ mod decl {`
`667`	`667`	`groupby: PyRef<PyItertoolsGroupBy>,`
`668`	`668`	`}`
`669`	`669`
`670`		`- #[pyclass(with(IterNext, Iterable))]`
	`670`	`+ #[pyclass(with(IterNext, Iterable), flags(HAS_WEAKREF))]`
`671`	`671`	`impl PyItertoolsGrouper {}`
`672`	`672`
`673`	`673`	`impl SelfIter for PyItertoolsGrouper {}`