Description
The layoutCallback of AmpStoryPageAttachment is throwing an error at main, which is generally causing the page attachment and its button to not appear. The cause appears to be that the this.element.querySelector('.i-amphtml-story-draggable-drawer-spacer') call returns null in the initializeListeners_() method of amp-story-draggable-drawer.js here. Upon further inspection, all of the attachment's child elements are all absent from the attachment at this point in the execution.
Running git bisect between the latest commit on main and an old working PR (#36133) appears to show that PR #36682 is the first bad commit. Assigning to the author and CCing the reviewers.
/cc @gmajoulet @processprocess @mszylkowski @jshamble
Reproduction Steps
- Run a local AMP server at main
- Go to http://0.0.0.0:8000/examples/amp-story/attachment.html
- Observe that each page's attachment is broken
Relevant Logs
No response
Browser(s) Affected
No response
OS(s) Affected
No response
Device(s) Affected
No response
AMP Version Affected
No response
Description
The
layoutCallbackofAmpStoryPageAttachmentis throwing an error at main, which is generally causing the page attachment and its button to not appear. The cause appears to be that thethis.element.querySelector('.i-amphtml-story-draggable-drawer-spacer')call returnsnullin theinitializeListeners_()method ofamp-story-draggable-drawer.jshere. Upon further inspection, all of the attachment's child elements are all absent from the attachment at this point in the execution.Running
git bisectbetween the latest commit on main and an old working PR (#36133) appears to show that PR #36682 is the first bad commit. Assigning to the author and CCing the reviewers./cc @gmajoulet @processprocess @mszylkowski @jshamble
Reproduction Steps
Relevant Logs
No response
Browser(s) Affected
No response
OS(s) Affected
No response
Device(s) Affected
No response
AMP Version Affected
No response