You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update:
Remove the multi line border radius code. It's creating motion inconsistency, giving uneven priority to the eye. It also does not provide utility, the two line text still renders with enough room.
Removing this will create visual consistency and remove code.
Mar-04-2022.10-32-39.mp4
The border radius work in #37186 regressed. Using [git bisect](https://git-scm.com/docs/git-bisect), the regression was introduced in #37195. It looks like selectors were updated in CSS but not in JS of that PR.
Visual diff tests were down when this regression was introduced so a diff was not triggered.
The three css selectors in styleTagText_ do not match between css and JS.
Description
Update:
Remove the multi line border radius code. It's creating motion inconsistency, giving uneven priority to the eye. It also does not provide utility, the two line text still renders with enough room.
Removing this will create visual consistency and remove code.
Spoke with @hongcatlover and they agree.
Mar-04-2022.10-32-39.mp4
The border radius work in #37186 regressed. Using [git bisect](https://git-scm.com/docs/git-bisect), the regression was introduced in #37195. It looks like selectors were updated in CSS but not in JS of that PR. Visual diff tests were down when this regression was introduced so a diff was not triggered.The three css selectors in
styleTagText_do not match between css and JS.The null checks and optional chaining can be removed since the work in #37793 runs this logic after the tag is created.
Multi-line border radius prior to regression:
Current:
