Issue (P0 Bug)
#38285
Pull Request(s)
#38285
AMP Version(s)
2206071918000, 2205270638000, 2204221712000
Channels
Beta / Experimental, Stable, LTS
Formats
Stories
Justification
This issue "breaks AMP (stories) in a significant way" by not allowing audio to play on videos.
When #36283 was merged it introduced the ability of the video cache to provide a has_audio signal that can mute the video. This was implemented in the video cache not long ago, but is not working properly. Multiple stories have videos whose signal is false but the video has audio, so it gets improperly muted (with no way to unmute it). Happens on origin (when opted in) and on the cache (on all stories).
Eg: https://nowthisnews.com/stories/depp-v-heard-trial-verdict/, https://www.thinkwithgoogle.com/consumer-insights/consumer-trends/trending-visual-stories/story/viewer-choice-reshapes-content/
Verification Steps
Click on one of the stories linked in the examples and verify they have audio again. Given that the video cache randomly changes the has_audio flag when re-ingesting the videos, we need to verify the response from the cache still returns has_audio=false but the video doesn't get muted (that would mean the issue was fixed).
Summary
No response
Impact
All stories on the AMP cache with videos can have some videos muted improperly (at random).
Action Items
No response
Notifications
/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers
Issue (P0 Bug)
#38285
Pull Request(s)
#38285
AMP Version(s)
2206071918000, 2205270638000, 2204221712000
Channels
Beta / Experimental, Stable, LTS
Formats
Stories
Justification
This issue "breaks AMP (stories) in a significant way" by not allowing audio to play on videos.
When #36283 was merged it introduced the ability of the video cache to provide a
has_audiosignal that can mute the video. This was implemented in the video cache not long ago, but is not working properly. Multiple stories have videos whose signal isfalsebut the video has audio, so it gets improperly muted (with no way to unmute it). Happens on origin (when opted in) and on the cache (on all stories).Eg: https://nowthisnews.com/stories/depp-v-heard-trial-verdict/, https://www.thinkwithgoogle.com/consumer-insights/consumer-trends/trending-visual-stories/story/viewer-choice-reshapes-content/
Verification Steps
Click on one of the stories linked in the examples and verify they have audio again. Given that the video cache randomly changes the
has_audioflag when re-ingesting the videos, we need to verify the response from the cache still returnshas_audio=falsebut the video doesn't get muted (that would mean the issue was fixed).Summary
No response
Impact
All stories on the AMP cache with videos can have some videos muted improperly (at random).
Action Items
No response
Notifications
/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers