Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: intuited/CloseableQueue
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ejd/CloseableQueue
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 7 files changed
  • 2 contributors

Commits on Jan 3, 2019

  1. py3: update CloseableQueue and tests to enable use under Python 3

    In `CloseableQueue.py`, the imports are now wrapped in a try/except
    block.  The new Python 3 imports are done in the `try` clause and the
    original Python 2 imports are left intact under the `except` clause.
    
    To update the tests, used a [recent version of test_queue.py][1] as a
    reference to find out how the mainline copy evolved since the creation
    of CloseableQueue.  I integrated the changes that allowed the test
    cases to run without crashing.
    
    [1]: https://github.com/python/cpython/blob/v3.7.2/Lib/test/test_queue.py
    ejd committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    f4840e3 View commit details
    Browse the repository at this point in the history
  2. py3: eliminate DeprecationWarnings

    In `CloseableQueue.py`, replace `raise StopIteration` with `return`,
    since [these are equivalent][1].  The deprecation is related to [PEP
    479][2].
    
    In the tests, `assertEquals` and `assert_` were replaced with
    `assertEqual` and `assertTrue`, respectively.  The old names were
    [deprecated in Python 3.2][3].
    
    [1]: https://docs.python.org/2/reference/simple_stmts.html#the-return-statement
    [2]: https://www.python.org/dev/peps/pep-0479/
    [3]: https://docs.python.org/3/library/unittest.html?highlight=unittest#deprecated-aliases
    ejd committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    818f7bd View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. add Python 3 classifier

    ejd committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    d0fc82a View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Merge pull request #1 from ejd/python-3-compatibility

    Python 3 compatibility
    ejd authored Feb 11, 2021
    Configuration menu
    Copy the full SHA
    d585ffa View commit details
    Browse the repository at this point in the history
  2. update docs and package metadata to prepare for fork

    This repository now contains a package known as CloseableQueue-py3.
    It is a universal, pure-Python package.  The documentation reflects
    the new name and repository URI.  The package metadata in setup.py now
    includes maintainer information in addition to the existing author
    information.
    ejd committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    9a3897a View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2 from ejd/CloseableQueue-py3-fork-preparation

    update docs and package metadata to prepare for fork
    ejd authored Feb 11, 2021
    Configuration menu
    Copy the full SHA
    0769075 View commit details
    Browse the repository at this point in the history
Loading