Skip to content

[Auth] Make two string properties atomic#14308

Merged
ncooke3 merged 1 commit into
mainfrom
nc/14196
Jan 7, 2025
Merged

[Auth] Make two string properties atomic#14308
ncooke3 merged 1 commit into
mainfrom
nc/14196

Conversation

@ncooke3
Copy link
Copy Markdown
Member

@ncooke3 ncooke3 commented Jan 6, 2025

Possible fix for #14196 until the SDK is fully synchronized with structured concurrency.

@google-oss-bot
Copy link
Copy Markdown
Collaborator

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ncooke3 ncooke3 requested a review from morganchen12 January 7, 2025 15:17
@ncooke3 ncooke3 marked this pull request as ready for review January 7, 2025 15:58
@ncooke3 ncooke3 merged commit e5a7384 into main Jan 7, 2025
@ncooke3 ncooke3 deleted the nc/14196 branch January 7, 2025 17:55
@paulb777
Copy link
Copy Markdown
Member

paulb777 commented Jan 7, 2025

@ncooke3 Should we add a changelog that notes fixing #14196?

@ncooke3
Copy link
Copy Markdown
Member Author

ncooke3 commented Jan 7, 2025

@ncooke3 Should we add a changelog that notes fixing #14196?

Yes, will roll it into the 11.7 changelog PR.

@ncooke3 ncooke3 linked an issue Jan 7, 2025 that may be closed by this pull request
@firebase firebase locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Crash] Auth.possiblyPostAuthStateChangeNotification() over released

4 participants