Skip to content

[Firebase AI] Make GenerativeAIRequest.Response Sendable#14947

Merged
andrewheard merged 4 commits into
mainfrom
ah/firebaseai-sendable-response
Jun 9, 2025
Merged

[Firebase AI] Make GenerativeAIRequest.Response Sendable#14947
andrewheard merged 4 commits into
mainfrom
ah/firebaseai-sendable-response

Conversation

@andrewheard
Copy link
Copy Markdown
Contributor

@andrewheard andrewheard commented Jun 9, 2025 •
edited
Loading

Updated the Response associated type for GenerativeAIRequest to require Sendable conformance. This resolves the warning Capture of non-sendable type 'T.Response.Type' in an isolated closure; this is an error in the Swift 6 language mode in Xcode 26 Beta 1.

Added Sendable conformance to CountTokensResponse and ImagenGenerationResponse<T> (and the two types used for T, ImagenInlineImage ImagenGCSImage).

#no-changelog

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Jun 9, 2025

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

paulb777
paulb777 approved these changes Jun 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on good CI

paulb777
paulb777 reviewed Jun 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good.

Add a changelog like - Fixed Sendable warnings introduced with Xcode 26 beta

@andrewheard andrewheard marked this pull request as ready for review June 9, 2025 23:14
@andrewheard andrewheard merged commit 229db86 into main Jun 9, 2025
60 checks passed
@andrewheard andrewheard deleted the ah/firebaseai-sendable-response branch June 9, 2025 23:38
@github-actions github-actions Bot mentioned this pull request Jun 24, 2025
Merged
cherylEnkidu pushed a commit that referenced this pull request Jun 30, 2025
@andrewheard @cherylEnkidu
[Firebase AI] Make GenerativeAIRequest.Response Sendable (#14947)
4b69595
@firebase firebase locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees

No one assigned

Labels

api: firebaseai

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewheard @paulb777