FirebaseApp: send Core Diagnostics data on appDidBecomeActive#3437
Conversation
| } | ||
| #pragma clang diagnostic pop | ||
|
|
||
| #pragma mark - App Life Cycle |
There was a problem hiding this comment.
Just FYI, there is some lifecycle code in GDTLifecycle. I'm not sure if you want to adopt that protocol or not.
There was a problem hiding this comment.
It will be nice to reuse it. Is GoogleDataTransport meant to be a required dependency for FirebaseCore?
cc @paulb777
There was a problem hiding this comment.
GDT won't come in if FirebaseCoreDiagnostics isn't present, so I wouldn't add a hard dependency on it.
|
|
||
| - (void)logDiagnostics { | ||
| if ([self isDataCollectionDefaultEnabled]) { | ||
| [FIRCoreDiagnosticsConnector logConfigureCoreWithOptions:_options]; |
There was a problem hiding this comment.
Did you want to create a new logging method, or keep as-is?
There was a problem hiding this comment.
I want to log the same data. Now I think, logConfigureCoreWithOptions can be renamed to something like logCoreDataWithOptions. WDYT?
…eDiagnostics methods in the tests.
| * @param options The options object containing data to log. | ||
| */ | ||
| + (void)logConfigureCoreWithOptions:(FIROptions *)options; | ||
| + (void)logCoreDataWithOptions:(FIROptions *)options; |
There was a problem hiding this comment.
maybe logCoreTelemetry? CoreData has a pretty specific meaning in iOS.
There was a problem hiding this comment.
yeah, logCoreTelemetry sounds better, thanks
|
FYI, this added a dependency from FirebaseCore to AppKit on macOS (for the symbol This causes Firestore on macOS to fail to link with this error: I think the fix is to add AppKit as a macOS dependency to the FirebaseCore pod. Does that seem right? |
|
Assuming the AppKit dependency is legitimate, #3459 is the fix. |
It is needed to send reliable heartbeats even if an application is not relaunched for a long time.