Update Firebase Storage directory structure#4573
Merged
Merged
Conversation
Contributor
|
Please update the Danger PR autolabeler as well: https://github.com/firebase/firebase-ios-sdk/blob/master/Dangerfile#L90 |
ryanwilson
reviewed
Jan 2, 2020
Member
ryanwilson
left a comment
There was a problem hiding this comment.
This LGTM but one concern I have is a large amount of the files showing up as new instead of moved - only worry being it's not as easy to see a blame of each file.
e99e39b to
31f9bce
Compare
Member
Author
|
Thanks for the push. There was an extra copy of those files. Now the diff should be right. |
ryanwilson
approved these changes
Jan 3, 2020
Member
ryanwilson
left a comment
There was a problem hiding this comment.
Much better diff, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/firebase/firebase-ios-sdk/blob/master/AddNewPod.md#directory-structure