Add functions spm unit and build tests#8499
Conversation
ncooke3
left a comment
There was a problem hiding this comment.
Nice! I think we should add watchos to the each matrix in functions.yml Here's one such matrix.
Coverage ReportAffected SDKsNo changes between base commit (c54fad2) and head commit (c7c29d7). Test Logs
|
|
Looks like |
This comment has been minimized.
This comment has been minimized.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
ncooke3
left a comment
There was a problem hiding this comment.
This LGTM 👍 . Added one comment about SwiftPM excludes as I havent seen that issue before
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
What should be done about incremental code coverage reports? I imagine these should not surface on tests? |
|
@granluo is working on the incremental coverage reporting separately. @jrcrespoh This PR should be good to resolve and merge here. |
Tests ran successfully with watchos
pod lib lintfails on travis for watchos, but succeeds locally. Disabling test for now, pending GHA update to Xcode 12.5+