Conversation
1 task
exaby73
approved these changes
May 30, 2024
TarekkMA
approved these changes
May 30, 2024
russellwheatley
approved these changes
May 30, 2024
kevmoo
reviewed
May 30, 2024
| } else if (value is DateTime) { | ||
| return Timestamp.fromDate(value); | ||
| // Cannot be done with Dart 3.2 constraints | ||
| // ignore: invalid_runtime_check_with_js_interop_types |
Contributor
There was a problem hiding this comment.
But this is invalid code, I think! Runtime behavior will be wrong w/ wasm!
There was a problem hiding this comment.
Drive-by comment:
It looks like both Dart values and JS values flow to value. In this case, I'd recommend checking all the Dart values first (is DateTime, etc.). After that, I'd cast value to a JSAny?, and then do isA checks with the resulting JSAny?. As an example:
if (value is DateTime) {
...
} else {
// Note that if value is still a Dart value, this cast is unsafe, so check all the Dart values first.
final jsValue = value as JSAny?;
if (jsValue.isA<GeoPointJsImpl>()) {
...
} else if (jsValue.isA<JSArray>()) {
List<JSAny?> list = (jsValue as JSArray).toDart;
...
}
}It also looks like there's a check against List<dynamic>. If value here is actually a JS array, use isA<JSArray>, as is List<dynamic> may be true when compiling to JS, but false when compiling to Wasm. The general guidance is that if a value is a JS value, use interop to type-check it and not Dart is checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
fixes #12820
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?