Skip to content

fix: update core, auth and app-check logic so internal resources on method channels are properly disposed#18268

Merged
russellwheatley merged 12 commits into
mainfrom
resolve-unfound-app-logic
May 11, 2026
Merged

fix: update core, auth and app-check logic so internal resources on method channels are properly disposed#18268
russellwheatley merged 12 commits into
mainfrom
resolve-unfound-app-logic

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

@russellwheatley russellwheatley commented May 11, 2026 •
edited
Loading

Description

  • skipped four tests that were consistently failing on CI, in relation to initialisation of multiple firebase apps or delete recreate app that curiously failed in CI but passed when running locally (Except the auth userChanges() on iOS which also fails locally). Needs further investigation.
  • Adds Firebase app service disposal support so registered plugin services are cleaned up before an app is deleted.
  • Updates Firebase Auth and App Check to unregister cached instances, close streams, cancel listener subscriptions, and create fresh instances after app deletion/reinitialization. Method channel resources were not being cleaned up on app delete with the latest FirebaseService implementation.
  • Simplifies iOS integration test CI by removing the retry path that could launch a second app instance. It was causing app to boot up when test runner was running tests already, and caused test failure on successful runs.
  • Removed duplicate entries for ai integration tests.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented May 11, 2026

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@russellwheatley russellwheatley changed the title test: update CI tests failing fix: update core, auth and app-check logic so internal resources on method channels are properly disposed May 11, 2026
@russellwheatley russellwheatley marked this pull request as ready for review May 11, 2026 16:03
@russellwheatley russellwheatley requested a review from Lyokone as a code owner May 11, 2026 16:03
@russellwheatley russellwheatley merged commit a0de4ed into main May 11, 2026
42 of 44 checks passed
@russellwheatley russellwheatley deleted the resolve-unfound-app-logic branch May 11, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demolaf demolaf demolaf approved these changes

@SelaseKay SelaseKay SelaseKay approved these changes

@Lyokone Lyokone Awaiting requested review from Lyokone Lyokone is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@russellwheatley @demolaf @SelaseKay