Merge pull request #3311 from pre-commit/sensible-regex-for-meta

asottile · web-flow · commit eec11bd1249f · 2024-09-30T18:16:05.000-04:00
also apply sensible regex warning for `repo: meta`
diff --git a/pre_commit/clientlib.py b/pre_commit/clientlib.py
@@ -289,6 +289,8 @@ def check(self, dct: dict[str, Any]) -> None:
         item
         for item in MANIFEST_HOOK_DICT.items
     ),
+    OptionalSensibleRegexAtHook('files', cfgv.check_string),
+    OptionalSensibleRegexAtHook('exclude', cfgv.check_string),
 )
 CONFIG_HOOK_DICT = cfgv.Map(
     'Hook', 'id',
diff --git a/tests/clientlib_test.py b/tests/clientlib_test.py
@@ -256,6 +256,24 @@ def test_validate_optional_sensible_regex_at_local_hook(caplog):
     ]
 
 
+def test_validate_optional_sensible_regex_at_meta_hook(caplog):
+    config_obj = {
+        'repo': 'meta',
+        'hooks': [{'id': 'identity', 'files': 'dir/*.py'}],
+    }
+
+    cfgv.validate(config_obj, CONFIG_REPO_DICT)
+
+    assert caplog.record_tuples == [
+        (
+            'pre_commit',
+            logging.WARNING,
+            "The 'files' field in hook 'identity' is a regex, not a glob "
+            "-- matching '/*' probably isn't what you want here",
+        ),
+    ]
+
+
 @pytest.mark.parametrize(
     ('regex', 'warning'),
     (

Original file line number	Diff line number	Diff line change
`@@ -289,6 +289,8 @@ def check(self, dct: dict[str, Any]) -> None:`
`289`	`289`	`item`
`290`	`290`	`for item in MANIFEST_HOOK_DICT.items`
`291`	`291`	`),`
	`292`	`+ OptionalSensibleRegexAtHook('files', cfgv.check_string),`
	`293`	`+ OptionalSensibleRegexAtHook('exclude', cfgv.check_string),`
`292`	`294`	`)`
`293`	`295`	`CONFIG_HOOK_DICT = cfgv.Map(`
`294`	`296`	`'Hook', 'id',`