gh-109375: Fix pdb alias command

buermarc · buermarc · commit 37a19695f51d · 2023-09-13T16:53:05.000+02:00
An unkown alias without a given command should not register a new alias.
diff --git a/Lib/pdb.py b/Lib/pdb.py
@@ -1755,6 +1755,8 @@ def do_alias(self, arg):
             return
         if args[0] in self.aliases and len(args) == 1:
             self.message("%s = %s" % (args[0], self.aliases[args[0]]))
+        elif len(args) == 1:
+            self.error("Unkown alias. To create an alias see 'help alias'")
         else:
             self.aliases[args[0]] = ' '.join(args[1:])
 
diff --git a/Lib/test/test_pdb.py b/Lib/test/test_pdb.py
@@ -664,8 +664,10 @@ def test_pdb_alias_command():
     ...     o.method()
 
     >>> with PdbTestInput([  # doctest: +ELLIPSIS
+    ...     'alias pi',
     ...     'alias pi for k in %1.__dict__.keys(): print(f"%1.{k} = {%1.__dict__[k]}")',
     ...     'alias ps pi self',
+    ...     'alias ps',
     ...     'pi o',
     ...     's',
     ...     'ps',
@@ -674,8 +676,12 @@ def test_pdb_alias_command():
     ...    test_function()
     > <doctest test.test_pdb.test_pdb_alias_command[1]>(4)test_function()
     -> o.method()
+    (Pdb) alias pi
+    *** Unkown alias. To create an alias see 'help alias'
     (Pdb) alias pi for k in %1.__dict__.keys(): print(f"%1.{k} = {%1.__dict__[k]}")
     (Pdb) alias ps pi self
+    (Pdb) alias ps
+    ps = pi self
     (Pdb) pi o
     o.attr1 = 10
     o.attr2 = str
diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-09-13-16-52-52.gh-issue-109375.ijJHZ9.rst b/Misc/NEWS.d/next/Core and Builtins/2023-09-13-16-52-52.gh-issue-109375.ijJHZ9.rst
@@ -0,0 +1 @@
+The pdb alias builtin now prevents registering aliases without a command.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+The pdb alias builtin now prevents registering aliases without a command.`