Python implementation of json.loads() accepts non-ascii digits #125682

New issue

Copy link

New issue

Copy link

Closed

Closed

Python implementation of json.loads() accepts non-ascii digits#125682

Copy link

Labels

3.12only security fixesonly security fixes3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixesstdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

nineteendo

opened on Oct 18, 2024

Issue body actions

Bug report

Bug description:

You should be careful when matching unicode regexes:

cpython/Lib/json/scanner.py

Lines 11 to 13 in a0f5c8e

	NUMBER_RE = re.compile(
	r'(-?(?:0|[1-9]\d*))(\.\d+)?([eE][-+]?\d+)?',
	(re.VERBOSE | re.MULTILINE | re.DOTALL))

>>> import sys
>>> sys.modules["_json"] = None
>>> import json
>>> json.loads("[1\uff10, 0.\uff10, 0e\uff10]")
[10, 0.0, 0.0]

I think it's safer to use [0-9] instead of \d here.

CPython versions tested on:

3.13

Operating systems tested on:

macOS

Linked PRs

• gh-125682: Python implementation of json.loads() accepts non-ascii digits #125687
• [3.13] gh-125682: Reject non-ASCII digits in the Python implementation of JSON decoder (GH-125687) #125692
• [3.12] gh-125682: Reject non-ASCII digits in the Python implementation of JSON decoder (GH-125687) #125693

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

Labels

3.12only security fixesonly security fixes3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixesstdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions