No NULL check in sqlite connection.c #129346

New issue

Copy link

New issue

Copy link

Closed

Closed

No NULL check in sqlite connection.c#129346

Copy link

Labels

3.12only security fixesonly security fixes3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixestopic-sqlite3type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

wooffie

opened on Jan 27, 2025

Issue body actions

Bug report

Bug description:

cpython/Modules/_sqlite/connection.c

Line 960 in 7ec1742

aggregate_instance = (PyObject**)sqlite3_aggregate_context(context, sizeof(PyObject*));

In this case we don'y check it against NULL, and can dereference in next line:

cpython/Modules/_sqlite/connection.c

Line 961 in 7ec1742

if (*aggregate_instance == NULL) {

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

• gh-129346: Handle allocation errors for SQLite aggregate context #129347
• [3.13] gh-129346: Handle allocation errors for SQLite aggregate context (GH-129347) #129372
• [3.12] gh-129346: Handle allocation errors for SQLite aggregate context (GH-129347) #129373

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

Labels

3.12only security fixesonly security fixes3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixestopic-sqlite3type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Projects

sqlite3 issues

Status

Done

Show more project fields

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions