fix(connectors): set syncContext.listingCapped in all connectors with caps

waleedlatif1 · claude · waleedlatif1 · commit 50182d154900 · 2026-03-26T18:31:14.000-07:00
OneDrive, Dropbox, SharePoint, Confluence (v2 + CQL), and Notion (3 listing
functions) now set syncContext.listingCapped = true when their respective
maxFiles/maxPages limit is hit. Without this, the sync engine's deletion
reconciliation would run against an incomplete listing and incorrectly
hard-delete documents that exist in the source but fell outside the cap window.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/apps/sim/connectors/confluence/confluence.ts b/apps/sim/connectors/confluence/confluence.ts
@@ -456,6 +456,7 @@ async function listDocumentsV2(
   const totalFetched = ((syncContext?.totalDocsFetched as number) ?? 0) + documents.length
   if (syncContext) syncContext.totalDocsFetched = totalFetched
   const hitLimit = maxPages > 0 && totalFetched >= maxPages
+  if (hitLimit && syncContext) syncContext.listingCapped = true
 
   return {
     documents,
@@ -621,6 +622,7 @@ async function listDocumentsViaCql(
   const totalFetched = ((syncContext?.totalDocsFetched as number) ?? 0) + documents.length
   if (syncContext) syncContext.totalDocsFetched = totalFetched
   const hitLimit = maxPages > 0 && totalFetched >= maxPages
+  if (hitLimit && syncContext) syncContext.listingCapped = true
 
   const totalSize = (data.totalSize as number) ?? 0
   const nextStart = start + results.length
diff --git a/apps/sim/connectors/dropbox/dropbox.ts b/apps/sim/connectors/dropbox/dropbox.ts
@@ -206,6 +206,7 @@ export const dropboxConnector: ConnectorConfig = {
     const totalFetched = previouslyFetched + documents.length
     if (syncContext) syncContext.totalDocsFetched = totalFetched
     const hitLimit = maxFiles > 0 && totalFetched >= maxFiles
+    if (hitLimit && syncContext) syncContext.listingCapped = true
 
     return {
       documents,
diff --git a/apps/sim/connectors/notion/notion.ts b/apps/sim/connectors/notion/notion.ts
@@ -454,6 +454,7 @@ async function listFromWorkspace(
   const totalFetched = ((syncContext?.totalDocsFetched as number) ?? 0) + documents.length
   if (syncContext) syncContext.totalDocsFetched = totalFetched
   const hitLimit = maxPages > 0 && totalFetched >= maxPages
+  if (hitLimit && syncContext) syncContext.listingCapped = true
 
   const nextCursor = hitLimit ? undefined : ((data.next_cursor as string) ?? undefined)
 
@@ -509,6 +510,7 @@ async function listFromDatabase(
   const totalFetched = ((syncContext?.totalDocsFetched as number) ?? 0) + documents.length
   if (syncContext) syncContext.totalDocsFetched = totalFetched
   const hitLimit = maxPages > 0 && totalFetched >= maxPages
+  if (hitLimit && syncContext) syncContext.listingCapped = true
 
   const nextCursor = hitLimit ? undefined : ((data.next_cursor as string) ?? undefined)
 
@@ -604,6 +606,7 @@ async function listFromParentPage(
   const totalFetched = ((syncContext?.totalDocsFetched as number) ?? 0) + documents.length
   if (syncContext) syncContext.totalDocsFetched = totalFetched
   const hitLimit = maxPages > 0 && totalFetched >= maxPages
+  if (hitLimit && syncContext) syncContext.listingCapped = true
 
   const nextCursor = hitLimit ? undefined : ((data.next_cursor as string) ?? undefined)
 
diff --git a/apps/sim/connectors/onedrive/onedrive.ts b/apps/sim/connectors/onedrive/onedrive.ts
@@ -239,6 +239,7 @@ export const onedriveConnector: ConnectorConfig = {
     const totalFetched = previouslyFetched + documents.length
     if (syncContext) syncContext.totalDocsFetched = totalFetched
     const hitLimit = maxFiles > 0 && totalFetched >= maxFiles
+    if (hitLimit && syncContext) syncContext.listingCapped = true
 
     const nextLink = data['@odata.nextLink']
 
diff --git a/apps/sim/connectors/sharepoint/sharepoint.ts b/apps/sim/connectors/sharepoint/sharepoint.ts
@@ -393,8 +393,8 @@ export const sharepointConnector: ConnectorConfig = {
 
     if (syncContext) syncContext.totalDocsFetched = totalFetched
     const hitLimit = maxFiles > 0 && totalFetched >= maxFiles
+    if (hitLimit && syncContext) syncContext.listingCapped = true
 
-    // Determine next cursor
     if (hitLimit) {
       return { documents, hasMore: false }
     }

Original file line number	Diff line number	Diff line change
`@@ -393,8 +393,8 @@ export const sharepointConnector: ConnectorConfig = {`
`393`	`393`
`394`	`394`	`if (syncContext) syncContext.totalDocsFetched = totalFetched`
`395`	`395`	`const hitLimit = maxFiles > 0 && totalFetched >= maxFiles`
	`396`	`+ if (hitLimit && syncContext) syncContext.listingCapped = true`
`396`	`397`
`397`		`- // Determine next cursor`
`398`	`398`	`if (hitLimit) {`
`399`	`399`	`return { documents, hasMore: false }`
`400`	`400`	`}`