Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: triggerdotdev/trigger.dev
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: triggerdotdev/trigger.dev
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: claude/fix-logger-trace-retry-9CXzO
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Mar 18, 2026

  1. fix(core): prevent errors inside logger.trace from breaking retry logic 

    Two fixes:

1. Reference examples called logger.trace() without await, which means
   errors thrown inside the callback become unhandled promise rejections
   that never reach the task executor's retry logic. Added await to all
   logger.trace() calls in the hello-world reference.

2. In TriggerTracer.startActiveSpan, the finally block's cleanup code
   (usage.stop, span.setAttributes) could throw and replace the original
   error being propagated from the catch block. Wrapped cleanup in
   try/catch to prevent this. Also fixed spanEnded flag not being set
   for isCompleteTaskWithOutput errors, which caused span.end() to be
   called twice.

https://claude.ai/code/session_017aBmbsohBhiu4ueddmtoGc
    @claude
    claude committed Mar 18, 2026
    Configuration menu
    Copy the full SHA
    da2205c View commit details
    Browse the repository at this point in the history
Loading