test: fix no-loop-func test with duplicate variable reports#19610
Merged
aladdin-add merged 1 commit intomainfrom Apr 8, 2025
Merged
test: fix no-loop-func test with duplicate variable reports#19610aladdin-add merged 1 commit intomainfrom
no-loop-func test with duplicate variable reports#19610aladdin-add merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
aladdin-add
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Fixes a
no-loop-functest that is currently failing on the main branch.The test was added in #19559, but in the meantime we merged #19595, which changes the expected error message.
What changes did you make? (Give an overview)
Updated the test to not expect the same variable to be reported multiple times.
Is there anything you'd like reviewers to focus on?