Missing well-known globals#3582
Merged
jugglinmike merged 2 commits intojshint:mainfrom Dec 27, 2021
acarstoiu:master
Merged
Conversation
BigInt for ES 11 Intl for node specify, xspecify for mocha
URLSearchParams for browser and node
Member
|
Thanks! |
coolaj86
reviewed
Dec 27, 2021
| setImmediate : true, // v0.9.1+ | ||
| clearImmediate : true, // v0.9.1+ | ||
| URL : true, // v6.13.0+ | ||
| URLSearchParams: true // v6.13.0+ |
Contributor
There was a problem hiding this comment.
Not that it matters too much, but URLSearchParams was introduced in v10.0.0+
Contributor
Author
There was a problem hiding this comment.
Damn, I really checked the history section of URLSearchParams. I saw it was introduced in v6.13.0, but didn't notice that it became a global variable only in v10.0.0.
Member
Contributor
Author
11: {
BigInt : false
}it does not work, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have no idea why this hasn't been noticed before, but some well-known globals are missing from
vars.js. Here's what I've added:This change is really easy to merge and I'm looking forward to seeing it in the next release.