feat(storage): Set CRC32C as the default checksum option (#7547)

thiyaguk09 · gemini-code-assist[bot] · pearigee · web-flow · commit 1a693aa3ade3 · 2026-04-14T09:52:52.000-07:00
* fix-Set crc32c as the default option

* code fix

Co-authored-by: gemini-code-assist[bot] &lt;176961590+gemini-code-assist[bot]@users.noreply.github.com&gt;

---------

Co-authored-by: gemini-code-assist[bot] &lt;176961590+gemini-code-assist[bot]@users.noreply.github.com&gt;
Co-authored-by: Gabe Pearhill &lt;86282859+pearigee@users.noreply.github.com&gt;
diff --git a/handwritten/storage/src/transfer-manager.ts b/handwritten/storage/src/transfer-manager.ts
@@ -129,7 +129,7 @@ export interface UploadFileInChunksOptions {
   uploadId?: string;
   autoAbortFailure?: boolean;
   partsMap?: Map<number, string>;
-  validation?: 'md5' | false;
+  validation?: 'md5' | 'crc32c' | false;
   headers?: {[key: string]: string};
 }
 
@@ -142,7 +142,7 @@ export interface MultiPartUploadHelper {
   uploadPart(
     partNumber: number,
     chunk: Buffer,
-    validation?: 'md5' | false,
+    validation?: 'md5' | 'crc32c' | false,
   ): Promise<void>;
   completeUpload(): Promise<GaxiosResponse | undefined>;
   abortUpload(): Promise<void>;
@@ -291,7 +291,7 @@ class XMLMultiPartUploadHelper implements MultiPartUploadHelper {
   async uploadPart(
     partNumber: number,
     chunk: Buffer,
-    validation?: 'md5' | false,
+    validation?: 'md5' | 'crc32c' | false,
   ): Promise<void> {
     const url = `${this.baseUrl}?partNumber=${partNumber}&uploadId=${this.uploadId}`;
     let headers: Headers = this.#setGoogApiClientHeaders();
@@ -301,6 +301,10 @@ class XMLMultiPartUploadHelper implements MultiPartUploadHelper {
       headers = {
         'Content-MD5': hash,
       };
+    } else if (validation === 'crc32c') {
+      const crc = new CRC32C();
+      crc.update(chunk);
+      headers['x-goog-hash'] = `crc32c=${crc.toString()}`;
     }
 
     return AsyncRetry(async bail => {
@@ -900,6 +904,7 @@ export class TransferManager {
     );
     let partNumber = 1;
     let promises: Promise<void>[] = [];
+    const validation = options.validation ?? 'crc32c';
     try {
       if (options.uploadId === undefined) {
         await mpuHelper.initiateUpload(options.headers);
@@ -917,9 +922,7 @@ export class TransferManager {
           promises = [];
         }
         promises.push(
-          limit(() =>
-            mpuHelper.uploadPart(partNumber++, curChunk, options.validation),
-          ),
+          limit(() => mpuHelper.uploadPart(partNumber++, curChunk, validation))
         );
       }
       await Promise.all(promises);
diff --git a/handwritten/storage/test/transfer-manager.ts b/handwritten/storage/test/transfer-manager.ts
@@ -938,5 +938,62 @@ describe('Transfer Manager', () => {
 
       assert(called);
     });
+
+    it('should use CRC32C validation when specified', async () => {
+      mockGeneratorFunction = (bucket, fileName, uploadId, partsMap) => {
+        fakeHelper = sandbox.createStubInstance(FakeXMLHelper);
+        fakeHelper.uploadId = uploadId || '';
+        fakeHelper.partsMap = partsMap || new Map<number, string>();
+        fakeHelper.initiateUpload.resolves();
+        fakeHelper.uploadPart.callsFake((partNumber, chunk, validation) => {
+          assert.strictEqual(validation, 'crc32c');
+
+          return Promise.resolve();
+        });
+        fakeHelper.completeUpload.resolves();
+        fakeHelper.abortUpload.resolves();
+        return fakeHelper;
+      };
+
+      await transferManager.uploadFileInChunks(
+        filePath,
+        {validation: 'crc32c'},
+        mockGeneratorFunction
+      );
+
+      assert.strictEqual(fakeHelper.uploadPart.calledOnce, true);
+    });
+
+    it('should apply crc32c validation by default', async () => {
+      let assertionMade = false;
+
+      mockGeneratorFunction = (bucket, fileName, uploadId, partsMap) => {
+        fakeHelper = sandbox.createStubInstance(FakeXMLHelper);
+        fakeHelper.uploadId = uploadId || '';
+        fakeHelper.partsMap = partsMap || new Map<number, string>();
+        fakeHelper.initiateUpload.resolves();
+
+        fakeHelper.uploadPart.callsFake((partNumber, chunk, validation) => {
+          // Confirm the validation is set to 'crc32c' by default.
+          assert.strictEqual(validation, 'crc32c');
+          assertionMade = true;
+          return Promise.resolve();
+        });
+
+        fakeHelper.completeUpload.resolves();
+        fakeHelper.abortUpload.resolves();
+        return fakeHelper;
+      };
+
+      // Call the function without specifying any validation option.
+      await transferManager.uploadFileInChunks(
+        filePath,
+        {},
+        mockGeneratorFunction
+      );
+
+      assert.strictEqual(fakeHelper.uploadPart.calledOnce, true);
+      assert.strictEqual(assertionMade, true);
+    });
   });
 });
