<view> elements should apply to the root element

Ahmad-S792 · Ahmad Saleem · commit 1018cb1de959 · 2025-09-02T15:18:52.000-07:00
https://bugs.webkit.org/show_bug.cgi?id=298206 Reviewed by Said Abou-Hallawa. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. Inspired by: https://chromium.googlesource.com/chromium/src.git/+/17ee10504ffe050b3926fa4be7262f8a21ac4e2d As the comment here indicates, it wasn't clear which <svg> a <view> element should apply to. This was clarified in SVG2 [1] to be the "root 'svg' element", which is the same as for a "svgView(...)" fragment. The comment is updated to reflect the new spec text and 'findRootAnchor' was updated to align with specification. [1] https://svgwg.org/svg2-draft/linking.html#SVGFragmentIdentifiersDefinitions * Source/WebCore/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::findRootAnchor const): (WebCore::SVGSVGElement::scrollToFragment): * LayoutTests/svg/as-image/resources/view-in-inner-svg.svg: Added. * LayoutTests/svg/as-image/view-in-inner-svg-expected.html: Added. * LayoutTests/svg/as-image/view-in-inner-svg.html: Added. Canonical link: https://commits.webkit.org/299459@main
diff --git a/LayoutTests/svg/as-image/resources/view-in-inner-svg.svg b/LayoutTests/svg/as-image/resources/view-in-inner-svg.svg
@@ -0,0 +1,7 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100">
+  <rect x="100" width="100" height="100" fill="green"/>
+  <svg>
+    <view id="innerview" viewBox="100 0 100 100"/>
+    <rect width="100" height="100" fill="red"/>
+  </svg>
+</svg>
diff --git a/LayoutTests/svg/as-image/view-in-inner-svg-expected.html b/LayoutTests/svg/as-image/view-in-inner-svg-expected.html
@@ -0,0 +1,2 @@
+<!DOCTYPE html>
+<div style="width: 100px; height: 100px; background-color: green"></div>
diff --git a/LayoutTests/svg/as-image/view-in-inner-svg.html b/LayoutTests/svg/as-image/view-in-inner-svg.html
@@ -0,0 +1,2 @@
+<!DOCTYPE html>
+<img src="resources/view-in-inner-svg.svg#innerview" width="100">
diff --git a/Source/WebCore/svg/SVGSVGElement.cpp b/Source/WebCore/svg/SVGSVGElement.cpp
@@ -700,7 +700,11 @@ RefPtr<SVGViewElement> SVGSVGElement::findViewAnchor(StringView fragmentIdentifi
 
 SVGSVGElement* SVGSVGElement::findRootAnchor(const SVGViewElement* viewElement) const
 {
-    return dynamicDowncast<SVGSVGElement>(SVGLocatable::nearestViewportElement(viewElement));
+    if (!viewElement)
+        return nullptr;
+
+    auto& document = viewElement->document();
+    return dynamicDowncast<SVGSVGElement>(document.documentElement());
 }
 
 SVGSVGElement* SVGSVGElement::findRootAnchor(StringView fragmentIdentifier) const
@@ -743,9 +747,9 @@ bool SVGSVGElement::scrollToFragment(StringView fragmentIdentifier)
     }
 
     // Spec: If the SVG fragment identifier addresses a "view" element within an SVG document (e.g., MyDrawing.svg#MyView)
-    // then the closest ancestor "svg" element is displayed in the viewport.
+    // then the root 'svg' element is displayed in the SVG viewport.
     // Any view specification attributes included on the given "view" element override the corresponding view specification
-    // attributes on the closest ancestor "svg" element.
+    // attributes on the root 'svg' element.
     if (RefPtr viewElement = findViewAnchor(fragmentIdentifier)) {
         if (RefPtr rootElement = findRootAnchor(viewElement.get())) {
             if (rootElement->m_currentViewElement) {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+<!DOCTYPE html>`
	`2`	`+<div style="width: 100px; height: 100px; background-color: green"></div>`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+<!DOCTYPE html>`
	`2`	`+<img src="resources/view-in-inner-svg.svg#innerview" width="100">`