[release/v7.5] Add version in description and pass store task on failure.#26896
[release/v7.5] Add version in description and pass store task on failure.#26896TravisEz13 wants to merge 1 commit intoPowerShell:release/v7.5from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR backports changes from #26885 to the release/v7.5 branch, enhancing the MSIX release pipeline by adding version information to the Microsoft Store app description and modifying error handling for store publish tasks.
Changes:
- Adds PowerShell version number to the top of the MSIX package description for better user visibility
- Updates variable syntax from
$(VAR)tovariables['VAR']in condition expressions for runtime variables - Adds
continueOnError: trueto both Stable/LTS and Preview store publishing tasks
| displayName: 'Publish StoreBroker Package (Stable/LTS)' | ||
| condition: and(ne('${{ parameters.skipMSIXPublish }}', 'true'), or(eq('$(STABLE)', 'true'), eq('$(LTS)', 'true'))) | ||
| condition: and(ne('${{ parameters.skipMSIXPublish }}', 'true'), or(eq(variables['STABLE'], 'true'), eq(variables['LTS'], 'true'))) | ||
| continueOnError: true |
There was a problem hiding this comment.
Using continueOnError: true on a critical publishing task is concerning. According to the PR description, this is added "because it always fails," but this suggests an underlying issue that should be investigated rather than suppressed.
Publishing to the Microsoft Store is a critical operation - if it's failing, the pipeline should alert on that failure so it can be investigated. Using continueOnError: true means the pipeline will appear to succeed even if publishing actually fails, which could result in releases not being published without anyone noticing.
Recommended approach:
- Investigate why the store-publish task is failing (authentication issues, API problems, configuration errors, etc.)
- Fix the root cause
- Only use
continueOnError: truefor non-critical diagnostic steps, not for critical operations like publishing
If there's a legitimate reason why this task should continue on error (e.g., the store has manual approval steps that cause the task to timeout but the submission still succeeds), that should be documented in a comment explaining the rationale.
| displayName: 'Publish StoreBroker Package (Preview)' | ||
| condition: and(ne('${{ parameters.skipMSIXPublish }}', 'true'), eq('$(PREVIEW)', 'true')) | ||
| condition: and(ne('${{ parameters.skipMSIXPublish }}', 'true'), eq(variables['PREVIEW'], 'true')) | ||
| continueOnError: true |
There was a problem hiding this comment.
Same concern as the Stable/LTS publish task - using continueOnError: true on a critical publishing operation masks failures and could result in releases not being published without detection.
This should either:
- Have the root cause of failures investigated and fixed, OR
- Include a comment explaining why continuing on error is necessary for this specific task
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Backport of #26885 to release/v7.5
Triggered by @TravisEz13 on behalf of @jshigetomi
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Improves the v7.5 MSIX release pipeline by adding version information to app description and enabling error continuation in store publish tasks for better error handling and release visibility.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Verified by running MSIX release pipeline on main branch. Changes to store publish tasks have been tested and confirmed to improve pipeline resilience and release note visibility without breaking existing functionality.
Risk
REQUIRED: Check exactly one box.
This modifies critical MSIX release pipeline steps. However, the changes have been tested in main and are localized to improving store publishing error handling and release note visibility. The variable syntax update aligns with best practices.
Merge Conflicts
One conflict in
.pipelines/templates/release-MSIX-Publish.ymlresolved by updating variable syntax from$(VAR)tovariables['VAR']and addingcontinueOnError: trueto both Stable/LTS and Preview store publish tasks, matching the intent of the original PR.