Skip to content

Add git_strarray wrapper #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianthomas23 merged 4 commits into from
Jul 17, 2025
Merged

Add git_strarray wrapper #17

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e04c96
add git_strarray wrapper
SandrineP Jul 16, 2025
c692454
move implementation to cpp file
SandrineP Jul 16, 2025
84563e2
small fix
SandrineP Jul 16, 2025
5e25e27
address review comments
SandrineP Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
small fix
  • Loading branch information
@SandrineP
SandrineP committed Jul 16, 2025
commit 84563e22ad2fdd171dee47ecb6bbb17b7403dd16
7 changes: 3 additions & 4 deletions src/utils/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,9 @@ git_strarray_wrapper::operator git_strarray*()

void git_strarray_wrapper::init_str_array()
{
git_strarray_wrapper aw;
git_strarray array{new char*[aw.m_patterns.size()], aw.m_patterns.size()};
for (size_t i=0; i<aw.m_patterns.size(); ++i)
git_strarray array{new char*[m_patterns.size()], m_patterns.size()};
for (size_t i=0; i<m_patterns.size(); ++i)
{
array.strings[i] = const_cast<char*>(aw.m_patterns[i].c_str());
array.strings[i] = const_cast<char*>(m_patterns[i].c_str());
}
}