Changed commands field to a dictionary, our problems are over.#48
Merged
Conversation
Collaborator
Author
|
That build failure was not me. |
BlueBeard63
reviewed
Mar 30, 2024
| @@ -80,9 +81,9 @@ private IRocketCommand GetCommand(IRocketCommand command) | |||
|
|
|||
| public IRocketCommand GetCommand(string command) | |||
There was a problem hiding this comment.
Would it not be possible to return a bool and out a IRocketCommand, then you dont have to check for null and just see if its a true or false return.
Collaborator
Author
There was a problem hiding this comment.
Not the scope of this PR.
BlueBeard63
approved these changes
Mar 30, 2024
BlueBeard63
left a comment
There was a problem hiding this comment.
Code is clean and well done, recommend merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made changes that prevent the module from taking a few seconds to execute a command when searching for it.
Resolves #43