Skip to content

[update_lib] Apply test grouping to deps #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 8 commits into from
Jan 24, 2026
Merged

[update_lib] Apply test grouping to deps #6867

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d18e8ce
quick resolve test path too
youknowone Jan 24, 2026
7cfcb08
Fix migrate resolve
youknowone Jan 24, 2026
58a7e75
Remove test/ from deps data
youknowone Jan 24, 2026
af3b64c
resolve test to lib
youknowone Jan 24, 2026
2398eb6
report original files
youknowone Jan 24, 2026
2922862
no default
youknowone Jan 24, 2026
32edb42
show hard deps on todo/deps
youknowone Jan 24, 2026
15950f1
Auto-format: ruff format
github-actions[bot] Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Auto-format: ruff format
  • Loading branch information
@github-actions
github-actions[bot] committed Jan 24, 2026
commit 15950f118234a9049ce8de348d3c63a9cf9fb480
12 changes: 3 additions & 9 deletions scripts/update_lib/deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,9 +554,7 @@ def resolve_test_to_lib(test_name: str) -> str | None:


@functools.cache
def get_lib_paths(
name: str, cpython_prefix: str
) -> tuple[pathlib.Path, ...]:
def get_lib_paths(name: str, cpython_prefix: str) -> tuple[pathlib.Path, ...]:
"""Get all library paths for a module.

Args:
Expand Down Expand Up @@ -616,9 +614,7 @@ def get_all_hard_deps(name: str, cpython_prefix: str) -> list[str]:


@functools.cache
def get_test_paths(
name: str, cpython_prefix: str
) -> tuple[pathlib.Path, ...]:
def get_test_paths(name: str, cpython_prefix: str) -> tuple[pathlib.Path, ...]:
"""Get all test paths for a module.

Args:
Expand Down Expand Up @@ -812,9 +808,7 @@ def _dircmp_is_same(dcmp) -> bool:


@functools.cache
def is_up_to_date(
name: str, cpython_prefix: str, lib_prefix: str
) -> bool:
def is_up_to_date(name: str, cpython_prefix: str, lib_prefix: str) -> bool:
"""Check if a module is up-to-date by comparing files.

Args:
Expand Down
11 changes: 3 additions & 8 deletions scripts/update_lib/show_todo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ def compute_todo_list(
# Get hard_deps and check their status
hard_deps = get_all_hard_deps(name, cpython_prefix)
hard_deps_status = {
hd: is_up_to_date(hd, cpython_prefix, lib_prefix)
for hd in hard_deps
hd: is_up_to_date(hd, cpython_prefix, lib_prefix) for hd in hard_deps
}

module_data[name] = {
Expand Down Expand Up @@ -339,9 +338,7 @@ def count_test_todos(test_name: str, lib_prefix: str) -> int:
return total


def is_test_tracked(
test_name: str, cpython_prefix: str, lib_prefix: str
) -> bool:
def is_test_tracked(test_name: str, cpython_prefix: str, lib_prefix: str) -> bool:
"""Check if a test exists in our local Lib/test."""
cpython_dir = pathlib.Path(cpython_prefix) / "Lib" / "test" / test_name
cpython_file = pathlib.Path(cpython_prefix) / "Lib" / "test" / f"{test_name}.py"
Expand All @@ -357,9 +354,7 @@ def is_test_tracked(
return local_path.exists()


def is_test_up_to_date(
test_name: str, cpython_prefix: str, lib_prefix: str
) -> bool:
def is_test_up_to_date(test_name: str, cpython_prefix: str, lib_prefix: str) -> bool:
"""Check if a test is up-to-date by comparing files.

Ignores lines containing 'TODO: RUSTPYTHON' in local files.
Expand Down