Skip to content

Remove some tests from PLATFORM_INDEPENDENT_TESTS#7459

Merged
youknowone merged 2 commits intoRustPython:mainfrom
ShaharNaveh:plat-indepent
Mar 18, 2026
Merged

Remove some tests from PLATFORM_INDEPENDENT_TESTS#7459
youknowone merged 2 commits intoRustPython:mainfrom
ShaharNaveh:plat-indepent

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Mar 17, 2026

Found while working on #7254

Summary by CodeRabbit

  • Chores
    • Updated CI/testing workflows by removing four test suites from automated checks.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: d7569199-574b-41dc-986d-f63ee9bff7be

📥 Commits

Reviewing files that changed from the base of the PR and between 0768cf8 and 404e84a.

⛔ Files ignored due to path filters (4)
  • Lib/test/test_class.py is excluded by !Lib/**
  • Lib/test/test_format.py is excluded by !Lib/**
  • Lib/test/test_math.py is excluded by !Lib/**
  • Lib/test/test_types.py is excluded by !Lib/**
📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yaml

📝 Walkthrough

Walkthrough

Four tests (test_class, test_format, test_math, test_types) were removed from the CI workflow's Python test suite configuration. These tests will no longer execute in the corresponding CI jobs.

Changes

Cohort / File(s) Summary
CI Test Configuration
.github/workflows/ci.yaml
Removed four test entries (test_class, test_format, test_math, test_types) from platform-independent test list and overall test suite.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • youknowone

Poem

🐰 Four tests hop away, gone but not forgotten,
The CI workflow cleans house, no code left rotten,
Simplicity reigns where redundancy once dwelt,
A lighter test suite is how progress is felt! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: removing tests from PLATFORM_INDEPENDENT_TESTS block in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh marked this pull request as ready for review March 17, 2026 14:52
@github-actions
Copy link
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] test: cpython/Lib/test/test_class.py (TODO: 16)
[x] test: cpython/Lib/test/test_genericclass.py
[x] test: cpython/Lib/test/test_subclassinit.py

dependencies:

dependent tests: (no tests depend on class)

[x] test: cpython/Lib/test/test_format.py (TODO: 7)

dependencies:

dependent tests: (no tests depend on format)

[x] test: cpython/Lib/test/test_math.py (TODO: 1)
[x] test: cpython/Lib/test/test_math_property.py

dependencies:

dependent tests: (229 tests)

  • math: test_abstract_numbers test_asyncio test_builtin test_cmath test_compile test_complex test_ctypes test_decimal test_descr test_float test_fractions test_json test_long test_math test_math_property test_monitoring test_numeric_tower test_pow test_random test_socket test_statistics test_struct test_time test_zipfile
    • fractions: test_buffer test_compare test_itertools test_operator test_os test_string
      • statistics: test_signal
    • random: test_asyncio test_bisect test_bz2 test_collections test_context test_dbm_dumb test_deque test_devpoll test_dict test_dummy_thread test_email test_functools test_heapq test_hmac test_importlib test_int test_io test_logging test_lzma test_mmap test_ordered_dict test_poll test_posixpath test_pprint test_queue test_regrtest test_richcmp test_selectors test_set test_shutil test_sort test_strtod test_sys test_tarfile test_thread test_threading test_tokenize test_traceback test_unparse test_uuid test_weakref test_zipfile test_zlib test_zstd
      • email.generator: test_email
      • email.utils: test_httpservers test_smtplib test_urllib2
      • imaplib: test_imaplib
      • secrets: test_secrets
      • tempfile: test_argparse test_ast test_asyncio test_bytes test_cmd_line test_compileall test_concurrent_futures test_contextlib test_csv test_ctypes test_dis test_doctest test_ensurepip test_faulthandler test_filecmp test_fileinput test_genericalias test_hashlib test_importlib test_inspect test_launcher test_linecache test_mailbox test_modulefinder test_ntpath test_pathlib test_pickle test_pkg test_pkgutil test_posix test_py_compile test_pydoc test_runpy test_site test_string_literals test_subprocess test_support test_tabnanny test_tempfile test_termios test_threadedtempfile test_tomllib test_urllib test_urllib_response test_venv test_winconsoleio test_zipapp test_zipfile64 test_zoneinfo
    • reprlib: test_reprlib
      • bdb: test_bdb
      • collections: test_annotationlib test_array test_asyncio test_c_locale_coercion test_call test_configparser test_contains test_copy test_ctypes test_defaultdict test_dictviews test_enum test_exception_group test_file test_fileio test_frame test_funcattrs test_hash test_ipaddress test_iter test_iterlen test_json test_pathlib test_patma test_plistlib test_shelve test_sqlite3 test_tuple test_types test_typing test_unittest test_userdict test_userlist test_userstring test_weakset test_with
      • dataclasses: test__colorize test_ctypes
    • selectors: test_asyncio
      • socket: test_asyncio test_epoll test_exception_hierarchy test_ftplib test_httplib test_kqueue test_largefile test_poplib test_pty test_smtpnet test_socketserver test_ssl test_stat test_timeout test_urllib2net test_urllibnet test_xmlrpc
      • socketserver: test_wsgiref
      • subprocess: test_android test_asyncio test_atexit test_audit test_cmd_line_script test_ctypes test_dtrace test_file_eintr test_gc test_gzip test_json test_msvcrt test_osx_env test_platform test_quopri test_repl test_script_helper test_select test_sysconfig test_unittest test_utf8_mode test_wait3 test_webbrowser
    • urllib.parse: test_urllib2_localnet test_urlparse
      • http.client: test_docxmlrpc test_ucn test_unicodedata
      • http.cookiejar: test_http_cookiejar
      • http.server: test_robotparser
      • logging.handlers: test_concurrent_futures
      • mimetypes: test_mimetypes
      • pathlib: test_dbm_sqlite3 test_importlib test_pathlib test_tomllib test_tools test_winapi test_zipfile
      • xml.sax.saxutils: test_sax

[x] lib: cpython/Lib/types.py
[ ] test: cpython/Lib/test/test_types.py (TODO: 8)

dependencies:

  • types

dependent tests: (52 tests)

  • types: test_annotationlib test_ast test_asyncgen test_asyncio test_builtin test_call test_code test_collections test_compile test_compiler_assemble test_coroutines test_decorators test_descr test_dis test_doctest test_dtrace test_dynamicclassattribute test_email test_enum test_exception_group test_fstring test_funcattrs test_generators test_genericalias test_hmac test_importlib test_inspect test_listcomps test_marshal test_monitoring test_opcache test_os test_positional_only_arg test_pprint test_pyclbr test_pydoc test_raise test_string test_subclassinit test_subprocess test_tempfile test_threading test_trace test_traceback test_type_aliases test_type_annotations test_type_params test_types test_typing test_unittest test_xml_etree test_xml_etree_c

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@youknowone youknowone merged commit f276598 into RustPython:main Mar 18, 2026
40 of 42 checks passed
youknowone pushed a commit to youknowone/RustPython that referenced this pull request Mar 19, 2026
* Remove some platform dependent tests

* Mark failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants