Add actionlint step by ShaharNaveh · Pull Request #7464 · RustPython/RustPython

ShaharNaveh · 2026-03-19T09:17:46Z

Summary by CodeRabbit

Chores
- Added an automated workflow check (reviewdog/action-actionlint) to catch configuration issues earlier.
- CI script improvements: expanded a Prettier install step into a multi-line script, and standardized path quoting/command formatting to avoid shell word-splitting and improve reliability.

coderabbitai · 2026-03-19T09:17:54Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Inserted a pinned reviewdog/action-actionlint step into the format_check job of .github/workflows/pr-format.yaml, and made several shell/quoting and minor script formatting edits in .github/workflows/ci.yaml. No other workflow control flow or step ordering was changed.

Changes

Cohort / File(s)	Summary
Format workflow `.github/workflows/pr-format.yaml`	Added a `reviewdog/action-actionlint` step to the `format_check` job, pinned to commit `0d952c597ef8459f634d7145b0b044a9699e5e43` (comment `v1.71.0`). Inserted immediately after `actions/checkout`; no other steps' conditions, inputs, commands, or ordering were modified.
CI workflow — shell/script tweaks `.github/workflows/ci.yaml`	Converted the `install prettier` step from a single-line `run` into a multi-line script. Quoted `export PATH` in the `wasm` job (`export PATH="$PATH:$(pwd)/../../geckodriver"`). Replaced backticked `pwd` with `$(pwd)` and quoted `--dir` and script path arguments in `wasm-wasi` `wasmer run` invocations to avoid shell word-splitting. No functional changes beyond quoting and script formatting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

youknowone

Poem

🐰 I hopped through lines of YAML bright,
Pinned a lint step, snug and tight.
Quoted paths and fixed the run,
Tiny changes, now we're done —
I munch a carrot in delight. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Add actionlint step' directly describes the main change: adding a new actionlint action to the workflow. However, the pull request also modifies ci.yaml with additional workflow improvements (Prettier installation refactoring, PATH quoting, and pwd command improvements), which are not captured in the title.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yaml:
- Around line 414-416: The redirect target in the CI step uses an unquoted
environment variable which can break if the path contains spaces; update the
command that appends the yarn global bin output (the line containing "yarn
global bin >> $GITHUB_PATH") to quote the redirect target (use >>
"$GITHUB_PATH") so it matches other workflow uses and is safe for paths with
spaces.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 5bfe84fc-b374-4669-b741-32747d77d0ab

📥 Commits

Reviewing files that changed from the base of the PR and between 5ca25af and f04bf86.

📒 Files selected for processing (2)

.github/workflows/ci.yaml
.github/workflows/pr-format.yaml

✅ Files skipped from review due to trivial changes (1)

.github/workflows/pr-format.yaml

.github/workflows/ci.yaml

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (1)

.github/workflows/ci.yaml (1)

414-416: ⚠️ Potential issue | 🟡 Minor

Quote $GITHUB_PATH in redirect target.

The unquoted $GITHUB_PATH triggers SC2086. Quote it for consistency with other workflows.

       - name: install prettier
         run: |
           yarn global add prettier
-          yarn global bin >> $GITHUB_PATH
+          yarn global bin >> "$GITHUB_PATH"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yaml around lines 414 - 416, Update the workflow step
that appends the yarn global bin path so the redirect target is quoted: change
the redirect from >> $GITHUB_PATH to >> "$GITHUB_PATH" in the run block (the
commands using yarn global bin and the $GITHUB_PATH variable) to avoid SC2086
and match other workflow usages.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yaml:
- Around line 556-558: The wasmer invocation uses an unquoted --dir argument
which can break on paths with spaces; update the second run step that currently
calls wasmer with --dir $(pwd) (the line running rustpython.wasm on
Lib/test/test_int.py) to quote the directory like --dir "$(pwd)" so both runs
are consistent and SC2046-safe.

---

Duplicate comments:
In @.github/workflows/ci.yaml:
- Around line 414-416: Update the workflow step that appends the yarn global bin
path so the redirect target is quoted: change the redirect from >> $GITHUB_PATH
to >> "$GITHUB_PATH" in the run block (the commands using yarn global bin and
the $GITHUB_PATH variable) to avoid SC2086 and match other workflow usages.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 87bef183-7ac0-4939-a830-c5cb3ded8270

📥 Commits

Reviewing files that changed from the base of the PR and between f04bf86 and 82ce530.

📒 Files selected for processing (1)

.github/workflows/ci.yaml

coderabbitai · 2026-03-19T09:40:29Z

.github/workflows/ci.yaml

+        run: wasmer run --dir $(pwd) target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/extra_tests/snippets/stdlib_random.py"
      - name: run cpython unittest
-        run: wasmer run --dir `pwd` target/wasm32-wasip1/release/rustpython.wasm -- `pwd`/Lib/test/test_int.py
+        run: wasmer run --dir $(pwd) target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/Lib/test/test_int.py"


⚠️ Potential issue | 🟡 Minor

Quote $(pwd) in --dir argument for consistency.

The script path is properly quoted, but --dir $(pwd) is not. This inconsistency triggers SC2046 and could fail if the working directory contains spaces.

- name: run snippets - run: wasmer run --dir $(pwd) target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/extra_tests/snippets/stdlib_random.py" + run: wasmer run --dir "$(pwd)" target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/extra_tests/snippets/stdlib_random.py" - name: run cpython unittest - run: wasmer run --dir $(pwd) target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/Lib/test/test_int.py" + run: wasmer run --dir "$(pwd)" target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/Lib/test/test_int.py"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

run: wasmer run --dir $(pwd) target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/extra_tests/snippets/stdlib_random.py"

- name: run cpython unittest

run: wasmer run --dir `pwd` target/wasm32-wasip1/release/rustpython.wasm -- `pwd`/Lib/test/test_int.py

run: wasmer run --dir $(pwd) target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/Lib/test/test_int.py"

run: wasmer run --dir "$(pwd)" target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/extra_tests/snippets/stdlib_random.py"

- name: run cpython unittest

run: wasmer run --dir "$(pwd)" target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/Lib/test/test_int.py"

🧰 Tools

🪛 GitHub Actions: Format Check

[warning] 556-556: actionlint (reviewdog) shellcheck reported issue: SC2046: Quote this to prevent word splitting (warning:1:18)

[warning] 558-558: actionlint (reviewdog) shellcheck reported issue: SC2046: Quote this to prevent word splitting (warning:1:18)

🪛 GitHub Check: format_check

[warning] 558-558:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:1:18: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/ci.yaml:558:9: shellcheck reported issue in this script: SC2046:warning:1:18: Quote this to prevent word splitting [shellcheck]

[warning] 556-556:
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:1:18: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/ci.yaml:556:9: shellcheck reported issue in this script: SC2046:warning:1:18: Quote this to prevent word splitting [shellcheck]

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yaml around lines 556 - 558, The wasmer invocation uses an unquoted --dir argument which can break on paths with spaces; update the second run step that currently calls wasmer with --dir $(pwd) (the line running rustpython.wasm on Lib/test/test_int.py) to quote the directory like --dir "$(pwd)" so both runs are consistent and SC2046-safe.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

ShaharNaveh added the skip:ci Skip running the ci label Mar 19, 2026

ShaharNaveh marked this pull request as ready for review March 19, 2026 09:19

ShaharNaveh force-pushed the actionlint branch 2 times, most recently from 538d6a3 to 7e47bed Compare March 19, 2026 09:28

ShaharNaveh added 2 commits March 19, 2026 10:32

Add actionlint step

e0bf0f8

Fix some lints

f04bf86

ShaharNaveh force-pushed the actionlint branch from 5ca25af to f04bf86 Compare March 19, 2026 09:33

ShaharNaveh added 2 commits March 19, 2026 10:34

Fix more lint

06661df

More

82ce530

coderabbitai bot reviewed Mar 19, 2026

View reviewed changes

.github/workflows/ci.yaml Outdated Show resolved Hide resolved

coderabbitai bot reviewed Mar 19, 2026

View reviewed changes

ShaharNaveh and others added 2 commits March 19, 2026 10:54

Update .github/workflows/ci.yaml

751c8ce

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

More

9cb0400

youknowone approved these changes Mar 19, 2026

View reviewed changes

youknowone merged commit b11b8e6 into RustPython:main Mar 19, 2026
9 checks passed

youknowone pushed a commit to youknowone/RustPython that referenced this pull request Mar 22, 2026

Add actionlint step (RustPython#7464)

4212c49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add actionlint step#7464

Add actionlint step#7464
youknowone merged 6 commits intoRustPython:mainfrom
ShaharNaveh:actionlint

ShaharNaveh commented Mar 19, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 19, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ShaharNaveh commented Mar 19, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShaharNaveh commented Mar 19, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 19, 2026 •

edited

Loading