feat: Feldera Engine Adapter#5791
Draft
fresioAS wants to merge 10 commits into
Draft
Conversation
… handling - Added support for CURRENT_TIMESTAMP in Feldera dialect. - Implemented `_insert_overwrite_by_condition` for efficient table replacement. - Enhanced `_is_virtual_layer_ddl` to identify virtual layer views. - Updated tests to cover new functionality and ensure correctness. Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for the Feldera database engine to the project. The changes include introducing a new Feldera connection configuration, implementing a Feldera engine adapter, registering the Feldera dialect, updating dependency and test configurations, and ensuring the new engine is integrated throughout the codebase.
These changes collectively enable SQLMesh to connect to, generate SQL for, and manage pipelines in Feldera, with appropriate configuration, dependency management, and test coverage.
Test Plan
Tested locally against a Docker Feldera instance with 10+ models, including tables, views, and materialized views. Verified end-to-end behavior for model deployment, query execution, and data ingestion.
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO