Make the prevent sync pattern generated from default_pattern.ignore stable#3147
Merged
Make the prevent sync pattern generated from default_pattern.ignore stable#3147
Conversation
touilleMan
approved these changes
Sep 26, 2022
| try: | ||
| # We need to reset `fnmatch._nextgroupnum` in order to make the pattern | ||
| # of the form `*a*` stable. | ||
| # Note: the `_nextgroupnum` counter has been removed in python 3.11 |
Contributor
There was a problem hiding this comment.
So from python 3.11 this bug is going to disappear no matter what ?
Contributor
Author
There was a problem hiding this comment.
Yes and no. The reason why the need for this groupnum counter disappear is the introduction of atomic grouping here:
python/cpython#31982
But those (?>...) groups are probably not going to be supported by the regex crate we're using in rust.
But I think it's something we can consider later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #3147