Conversation
Add a GitHub Actions workflow that runs lint, type checking, and unit tests on every push to a PR targeting main or v1.x. Includes test fixture updates.
The separate build + test:unit steps caused snapshot mismatches because pnpm build does not set VITEST=1, which gets inlined at build time. Using test-ci runs test:prepare (which builds with .env.test setting VITEST=1) followed by test:unit, matching local test behavior.
The test was failing on CI because git's default branch name may not be 'main'. Using --initial-branch main ensures consistent behavior.
BarrensZeppelin
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainorv1.xTest plan
Note
Low Risk
Low risk: adds CI automation and updates test expectations for existing CLI flags/return shapes, without changing runtime behavior.
Overview
Adds a new GitHub Actions
CIworkflow that runs on pushes and PRs tomain/v1.x, executing lint and typecheck on Node 22 and running build + unit tests across a Node20/22/24matrix.Updates test snapshots/expectations to reflect new CLI help flags (
--disable-external-tool-checksand--reach-disable-external-tool-checks) and a result field rename fromfixedtofixedAllincoanaFixtests.Written by Cursor Bugbot for commit 240823a. Configure here.