Add default configuration for analytic vendors.#7034
Merged
Conversation
5e5f3bd to
1a5500c
Compare
| import { AMPNotice, NOTICE_SIZE_SMALL } from '../components/amp-notice'; | ||
| import vendorConfigs from './vendor-configs'; | ||
|
|
||
| const GOOGLE_ANALYTICS_VENDOR = 'googleanalytics'; |
Collaborator
There was a problem hiding this comment.
do we still need this?
Collaborator
Author
There was a problem hiding this comment.
Yes, This variable is used below for message.
Collaborator
|
@dhaval-parekh should we add a notice with (link) for 10 vendors something like 🔗 "Learn More" pointing to the respective vendor's documentation link Example: |
Collaborator
Author
Yes, We can add it. Let me check if i can find the documentation for those vendors. |
1a5500c to
1f2a039
Compare
Contributor
|
Plugin builds for 16d597c are ready 🛎️!
|
1f2a039 to
21f9ddb
Compare
Member
|
There's an E2E test failing, but I'm updating with |
westonruter
requested changes
Apr 21, 2022
Member
westonruter
left a comment
There was a problem hiding this comment.
The E2E tests need to be fixed.
westonruter
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7019
Pre-fill default config when the user selects analytic vendor on the AMP setting page.
analytic-default-config.mov
Checklist