Fix margin usage of p.has-background in legacy theme#7496
Merged
Conversation
…-article-content` - Update style.php in legacy theme
40a5233 to
e1a3e7a
Compare
Contributor
|
Plugin builds for 3af490b are ready 🛎️!
|
westonruter
reviewed
Mar 21, 2023
Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
approved these changes
Mar 21, 2023
Member
westonruter
left a comment
There was a problem hiding this comment.
This fixes the specific issue, but we'll need to revisit a more holistic approach to ensure block styles are applied properly in Legacy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discovered in #7471 (comment), updated usage(in 7996b3a) for
p.has-background(if font-size is xxl) is breaking other elements withp.has-background. This PR ensures that margins only get updated ifp.has-backgroundis a descendant of.amp-wp-article-content.Before:
After:
Checklist