Skip to content

Update Build, test & measure workflow#7649

Merged
westonruter merged 26 commits into
developfrom
enhancement/workflows
Oct 30, 2023
Merged

Update Build, test & measure workflow#7649
westonruter merged 26 commits into
developfrom
enhancement/workflows

Conversation

@thelovekesh
Copy link
Copy Markdown
Collaborator

@thelovekesh thelovekesh commented Oct 29, 2023 •
edited
Loading

Summary

  • Remove generate-changelog script and draft-release action.
  • Decouple the following jobs as re-usable composite workflows:
    • Setup Node and NPM: Setup Node/NPM; Installs and caches dependencies.
    • Setup PHP and Composer: Setup PHP/Composer; Installs and cache dependencies;
    • Determine modified files; Determine modified file counts; Add GitHub workflow summary
    • Build Plugin: Build plugin assets and cache them if the package-lock.json and files within the ./assets directory are the same.
  • Hardened GITHUB_TOKEN permissions in all workflows. Closes chore: Set permissions for GitHub actions #7160.
  • Split E2E tests in batches to avoid longer wait times in CI.
  • Generate assets checksums; Add checksums to build assets PR comment; Upload checksums to GCP storage for base branch assets.
  • Remove code coverage steps from the feature tests.
  • Replace peter-evans/create-or-update-comment@v3 with official actions/github-script@v6 action to post comments on PR.
  • Remove the composer normalize job and move it to Lint PHP job which uses globally installed composer-normalize

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh force-pushed the enhancement/workflows branch from b489f48 to 70bb977 Compare October 29, 2023 20:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 29, 2023 •
edited
Loading

Plugin builds for c86bdb1 are ready 🛎️!

Checksums 
# Development build checksums
5fc3355870350e82ab6eb235f1bfea30f91407ce918c7f3ad106013f04941abf *amp.zip

# Production build checksums
184bad5a82607954c00982c073e1a1cd851d81e48fb2ce25d8420f59a489b9ce *amp.zip

Warning

These builds are for testing purposes only and should not be used in production.

@thelovekesh thelovekesh force-pushed the enhancement/workflows branch from f985c64 to b1835ff Compare October 30, 2023 07:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #7649 (74e75b4) into develop (c1332cc) will decrease coverage by 73.03%.
Report is 2 commits behind head on develop.
The diff coverage is 0.00%.

❗ Current head 74e75b4 differs from pull request most recent head ae84b4e. Consider uploading reports for the commit ae84b4e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #7649       +/-   ##
=============================================
- Coverage      77.34%   4.31%   -73.03%     
+ Complexity      6902    6893        -9     
=============================================
  Files            210     277       +67     
  Lines          22173   17852     -4321     
=============================================
- Hits           17150     771    -16379     
- Misses          5023   17081    +12058
Flag Coverage Δ
javascript 64.73% <ø> (?)
php 0.00% <0.00%> (-77.35%) ⬇️
unit 0.00% <0.00%> (-77.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
includes/deprecated.php 0.00% <ø> (ø)
includes/sanitizers/class-amp-bento-sanitizer.php 0.00% <ø> (ø)
src/Admin/SiteHealth.php 0.00% <ø> (-65.85%) ⬇️
amp.php 0.00% <0.00%> (ø)

... and 261 files with indirect coverage changes

@thelovekesh thelovekesh force-pushed the enhancement/workflows branch from 74e75b4 to ae84b4e Compare October 30, 2023 11:45
@westonruter westonruter added this to the v2.5.0 milestone Oct 30, 2023
westonruter
westonruter reviewed Oct 30, 2023
View reviewed changes
Comment thread .github/actions/setup-node-npm/action.yml Outdated
Comment thread .github/actions/setup-node-npm/action.yml Outdated
Comment thread .github/actions/setup-node-npm/action.yml Outdated
@thelovekesh @westonruter
Update tools names
c86bdb1 
Co-authored-by: Weston Ruter <westonruter@google.com>
@westonruter westonruter merged commit 6899eeb into develop Oct 30, 2023
@westonruter westonruter deleted the enhancement/workflows branch October 30, 2023 19:58
@thelovekesh thelovekesh mentioned this pull request Nov 1, 2023
Closed
2 tasks
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

No one assigned

Labels

Changelogged Whether the issue/PR has been added to release notes.

Projects

None yet

Milestone

v2.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thelovekesh @westonruter