Skip to content

🐛 [Amp story] Null check on screen.orientation #35639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
processprocess merged 1 commit into from
Aug 12, 2021
Merged

🐛 [Amp story] Null check on screen.orientation #35639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Null check on orientation lock.
  • Loading branch information
@processprocess
processprocess committed Aug 12, 2021
commit 5adb01e88918740f63197ca12c607f45118ae3a9
2 changes: 1 addition & 1 deletion extensions/amp-story/1.0/amp-story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,7 @@ export class AmpStory extends AMP.BaseElement {
}

const lockOrientation =
screen.orientation.lock ||
screen.orientation?.lock ||
screen.lockOrientation ||
screen.mozLockOrientation ||
screen.msLockOrientation ||
Expand Down