Skip to content

🚮 [amp story 360] Remove unnecessary .then statement #36409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
processprocess merged 2 commits into from
Oct 20, 2021
Merged

🚮 [amp story 360] Remove unnecessary .then statement #36409

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
877111d
Remove unnecessary .then
processprocess Oct 19, 2021
a2651a4
remove log.
processprocess Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove unnecessary .then
  • Loading branch information
@processprocess
processprocess committed Oct 19, 2021
commit 877111d366a9dca9534a32b055d4974c9d9a7372
3 changes: 2 additions & 1 deletion extensions/amp-story-360/0.1/amp-story-360.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ export class AmpStory360 extends AMP.BaseElement {
this.localizationService_ = localizationService;
}
),
]).then(() => Promise.resolve());
]);
}

/**
Expand Down Expand Up @@ -665,6 +665,7 @@ export class AmpStory360 extends AMP.BaseElement {

/** @override */
layoutCallback() {
console.log('layoutCallback');
const ampImgEl = this.element.querySelector('amp-img');
// Used to update the video in animate_.
this.ampVideoEl_ = this.element.querySelector('amp-video');
Expand Down