Skip to content

🐛 [amp-story-page-outlink] Force page outlinks to use target='_top' in order to prevent navigation from breaking on Safari #36428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coreymasanto merged 5 commits into from
Oct 21, 2021
Merged

🐛 [amp-story-page-outlink] Force page outlinks to use target='_top' in order to prevent navigation from breaking on Safari #36428

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9208cb
Force page outlinks to use target='_top' in order to prevent them fro…
coreymasanto Oct 20, 2021
0de39dc
Lint
coreymasanto Oct 20, 2021
4a8be05
Add test-amp-story-page-attachment.js with basic attachment and outli…
coreymasanto Oct 21, 2021
358e90b
Merge branch 'main' into outlink
coreymasanto Oct 21, 2021
39332cf
Lint
coreymasanto Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Lint
  • Loading branch information
@coreymasanto
coreymasanto committed Oct 21, 2021
commit 39332cf841aacf2b5f5a55fe9e3c13c1af6d7bfd
4 changes: 2 additions & 2 deletions extensions/amp-story/1.0/test/test-amp-story-page-attachment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ describes.realWin('amp-story-page-attachment', {amp: true}, (env) => {
let outlink;

beforeEach(() => {
const win = env.win;
const {win} = env;

// Set up the story.
const storyEl = win.document.createElement('amp-story');
Expand Down Expand Up @@ -47,7 +47,7 @@ describes.realWin('amp-story-page-attachment', {amp: true}, (env) => {
it('should build amp-story-page-outlink with target="_top" even when the publisher has specified a different value', async () => {
const anchorEl = outlinkEl.querySelector('amp-story-page-outlink a');
anchorEl.setAttribute('target', '_blank');

outlink.buildCallback();
await outlink.layoutCallback();

Expand Down