Skip to content

✨ Add volume attribute to amp-video for use in amp-story-page #36693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmajoulet merged 8 commits into from
Nov 2, 2021
Merged

✨ Add volume attribute to amp-video for use in amp-story-page #36693

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4fc40b5
Add volume support in amp-video for amp-story.
Oct 26, 2021
f80e2aa
Merge branch 'main' into volume
Oct 26, 2021
2bd8317
Parse volume string to float.
Oct 26, 2021
6d46cb1
Update regex for volume.
Nov 1, 2021
b5809eb
Merge branch 'main' into volume
Nov 1, 2021
03bc0ad
Update extensions/amp-story/1.0/media-pool.js
apatronl Nov 2, 2021
4dc16c6
Add validator test cases.
Nov 2, 2021
ef94f91
Merge branch 'main' into volume
Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update extensions/amp-story/1.0/media-pool.js 
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
  • Loading branch information
@apatronl @gmajoulet
2 people authored and Ale Patron committed Nov 2, 2021
commit 03bc0adc6f78adb01219132f40491a01ff85a318
15 changes: 6 additions & 9 deletions extensions/amp-story/1.0/media-pool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,12 +852,9 @@ export class MediaPool {

// When a video is muted, reset its volume to the default value of 1.
if (mediaType == MediaType.VIDEO) {
let parent = domMediaEl.parentElement;
if (parent) {
domMediaEl.volume = 1;
}
domMediaEl.volume = 1;
}

return this.enqueueMediaElementTask_(poolMediaEl, new MuteTask());
}

Expand All @@ -879,11 +876,11 @@ export class MediaPool {
}

if (mediaType == MediaType.VIDEO) {
let parent = domMediaEl.parentElement;
if (parent) {
let volume = parent.getAttribute('volume');
const ampVideoEl = domMediaEl.parentElement;
if (ampVideoEl) {
const volume = ampVideoEl.getAttribute('volume');
if (volume) {
domMediaEl.volume = Number.parseFloat(volume);
domMediaEl.volume = parseFloat(volume);
}
}
}
Expand Down