Skip to content

🚀 [Story embeds] Remove support for expanded components like amp-twitter #36851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mszylkowski merged 14 commits into from
Nov 11, 2021
Merged

🚀 [Story embeds] Remove support for expanded components like amp-twitter #36851

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e4f1956
Working removal
mszylkowski Nov 8, 2021
b5db57f
Removed extra styles / vars
mszylkowski Nov 8, 2021
fc37c15
Keep removing
mszylkowski Nov 9, 2021
e58de03
Removed more
mszylkowski Nov 9, 2021
94898c0
Merge branch 'main' of github.com:ampproject/amphtml into remove_embe…
mszylkowski Nov 9, 2021
44d80f2
Started removing languages
mszylkowski Nov 9, 2021
001344c
Removing localizatino strings
mszylkowski Nov 9, 2021
5c8ebf0
Removed other localizations
mszylkowski Nov 9, 2021
a2541aa
Removed remaining expand tweet
mszylkowski Nov 9, 2021
84d53e5
Updated zindex
mszylkowski Nov 9, 2021
29fdca8
Removed visual tests
mszylkowski Nov 10, 2021
0c9113a
Removed unused const
mszylkowski Nov 10, 2021
cd10a57
Adding click shield to tweet
mszylkowski Nov 10, 2021
f2aa242
Merge branch 'main' of github.com:ampproject/amphtml into remove_embe…
mszylkowski Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed visual tests
  • Loading branch information
@mszylkowski
mszylkowski committed Nov 10, 2021
commit 29fdca816aa122d21d3795d03a349f06d33e7f70
29 changes: 0 additions & 29 deletions examples/visual-tests/amp-story/amp-story-tooltip-desktop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,21 +52,6 @@ module.exports = {
await page.waitForTimeout(800); // For animations to finish.
await verifySelectorsVisible(page, name, ['amp-story-page#page-3[active]']);
},
'tapping on embed tooltip should expand the component': async (
page,
name
) => {
await page.tap('.next-container > button.i-amphtml-story-button-move');
await page.waitForSelector('amp-story-page#page-2[active]');
await page.waitForTimeout(300); // For animations to finish.
await page.tap('amp-twitter.interactive-embed');
await page.waitForTimeout(300); // For animations to finish.
await page.tap('a.i-amphtml-story-tooltip');
await page.waitForTimeout(800); // For animations to finish.
await verifySelectorsVisible(page, name, [
'amp-story-page.i-amphtml-expanded-mode',
]);
},
'tapping on non-interactive embed should not show tooltip or block navigation':
async (page, name) => {
await page.tap('.next-container > button.i-amphtml-story-button-move');
Expand All @@ -82,18 +67,4 @@ module.exports = {
'amp-story-page#page-4[active]',
]);
},
'tapping on closing button should exit expanded view': async (page, name) => {
await page.tap('.next-container > button.i-amphtml-story-button-move');
await page.waitForSelector('amp-story-page#page-2[active]');
await page.waitForTimeout(300); // For animations to finish.
await page.tap('amp-twitter.interactive-embed');
await page.waitForTimeout(300); // For animations to finish.
await page.tap('a.i-amphtml-story-tooltip');
await page.waitForSelector('amp-story-page.i-amphtml-expanded-mode');
await page.waitForTimeout(800); // For animations to finish.
await page.tap('span.i-amphtml-expanded-view-close-button');
await verifySelectorsInvisible(page, name, [
'amp-story-page.i-amphtml-expanded-mode',
]);
},
};
34 changes: 0 additions & 34 deletions examples/visual-tests/amp-story/amp-story-tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,23 +44,6 @@ module.exports = {
await page.waitForTimeout(150); // For animations to finish.
await verifySelectorsVisible(page, name, ['amp-story-page#cover[active]']);
},
'tapping on embed tooltip should expand the component': async (
page,
name
) => {
const screen = page.touchscreen;
await screen.tap(200, 240);
await page.waitForSelector('amp-story-page#page-2[active]');
await page.waitForTimeout(800); // For animations to finish.
await page.tap('amp-twitter.interactive-embed');
await page.waitForSelector('a.i-amphtml-story-tooltip');
await page.waitForTimeout(500); // For animations to finish.
await page.tap('a.i-amphtml-story-tooltip');
await page.waitForTimeout(1000); // For animations to finish.
await verifySelectorsVisible(page, name, [
'amp-story-page.i-amphtml-expanded-mode',
]);
},
'tapping on non-interactive embed should not show tooltip or block navigation':
async (page, name) => {
const screen = page.touchscreen;
Expand All @@ -77,21 +60,4 @@ module.exports = {
'amp-story-page#page-2[active]',
]);
},
'tapping on closing button should exit expanded view': async (page, name) => {
const screen = page.touchscreen;
await screen.tap(200, 240);
await page.waitForSelector('amp-story-page#page-2[active]');
await page.waitForTimeout(800); // For animations to finish.
await page.tap('amp-twitter.interactive-embed');
await page.waitForSelector('a.i-amphtml-story-tooltip');
await page.waitForTimeout(500); // For animations to finish.
await page.tap('a.i-amphtml-story-tooltip');
await page.waitForSelector('amp-story-page.i-amphtml-expanded-mode');
await page.waitForTimeout(1000); // For animations to finish.
await page.tap('button.i-amphtml-expanded-view-close-button');
await page.waitForTimeout(300); // For animations to finish.
await verifySelectorsInvisible(page, name, [
'amp-story-page.i-amphtml-expanded-mode',
]);
},
};
4 changes: 0 additions & 4 deletions extensions/amp-story/1.0/_locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,5 @@
"100": {
"string": "Read more",
"description": "Label for a button to open a drawer containing additional content."
},
"101": {
"string": "Open Tweet",
"description": "Label in the tooltip text for when a Twitter embed can be opened."
}
}
3 changes: 0 additions & 3 deletions extensions/amp-story/1.0/amp-story-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,9 +531,6 @@ export class AmpStoryPage extends AMP.BaseElement {
this.backgroundAudioDeferred_.resolve();

this.muteAllMedia();
this.getViewport().onResize(
debounce(this.win, () => this.onResize_(), RESIZE_TIMEOUT_MS)
);

this.renderOpenAttachmentUI_();

Expand Down