Skip to content

♻️[amp story 360] Use JSX #36942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
processprocess merged 7 commits into from
Nov 16, 2021
Merged

♻️[amp story 360] Use JSX #36942

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b4337e6
Use jsx instead of htmlfor
processprocess Nov 16, 2021
6a43a60
Implicit returns.
processprocess Nov 16, 2021
c742be4
Merge branch 'main' into 360-jsx
processprocess Nov 16, 2021
ff36d99
Lint
processprocess Nov 16, 2021
582fc5a
Remove superfluous argument.
processprocess Nov 16, 2021
f3bc606
Lint
processprocess Nov 16, 2021
4c0158c
Merge branch 'ampproject:main' into 360-jsx
processprocess Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into 360-jsx
  • Loading branch information
@processprocess
processprocess authored Nov 16, 2021
commit c742be42d6b97416df5cba5b816939e224b70771
2 changes: 1 addition & 1 deletion extensions/amp-story-360/0.1/amp-story-360.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

import * as Preact from '#core/dom/jsx';
import {CommonSignals} from '#core/constants/common-signals';
import {CommonSignals_Enum} from '#core/constants/common-signals';
import {whenUpgradedToCustomElement} from '#core/dom/amp-element-helpers';
import {applyFillContent, isLayoutSizeDefined} from '#core/dom/layout';
import {closest} from '#core/dom/query';
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.