Skip to content

🌐 Added RTL ordering i18n for amp story shopping tag #37252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jshamble merged 8 commits into from
Jan 5, 2022
+141 −1
Merged

🌐 Added RTL ordering i18n for amp story shopping tag #37252

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
23d8043
added amp story shopping trl
jshamble Dec 21, 2021
0b3d1eb
added correct margin apdding for rtl elements
jshamble Dec 23, 2021
5a52541
added correct rtl toggle ordering
jshamble Dec 28, 2021
17095d9
added vis diff test
jshamble Dec 28, 2021
07614ba
removed some old code, added in mutate element for rtl state chagne
jshamble Dec 28, 2021
ea8d397
resolved merge conflict
jshamble Dec 28, 2021
d01823d
refcatored someo f the rtl code
jshamble Jan 5, 2022
bc98f5a
fixed commint nit
jshamble Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixed commint nit
  • Loading branch information
@jshamble
jshamble committed Jan 5, 2022
commit bc98f5af73e19b5c10d88930bd4c21cc43e84ab9
3 changes: 1 addition & 2 deletions examples/amp-story/amp-story-shopping.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@
</amp-story-page>
<amp-story-page id="inline-light-theme" dir="rtl">
<!--
Example of Inline config. Multiple product tags with icon defined, right to left language direction.
In order for this to work as intended, you must specify dir="rtl" in the <html> tag.
RTL example
-->
<amp-story-shopping-config layout="nodisplay">
<script type="application/json">
Expand Down
3 changes: 1 addition & 2 deletions examples/visual-tests/amp-story/amp-story-shopping.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@
</amp-story-page>
<amp-story-page id="inline-light-theme" dir="rtl">
<!--
Example of Inline config. Multiple product tags with icon defined, right to left language direction.
In order for this to work as intended, you must specify dir="rtl" in the <html> tag.
RTL example
-->
<amp-story-shopping-config layout="nodisplay">
<script type="application/json">
Expand Down