-
Notifications
You must be signed in to change notification settings - Fork 4.1k
🚀 [Story video] Use the inlined video response instead of issuing an XHR request, for the 1st video of the 1st web story page #37499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
163b8f7
For the first video of the first web story page, use the inlined vide…
coreymasanto 0819baf
Fix merge conflict
coreymasanto cf79773
Refactor to prevent unnecessary XHR-related function calls
coreymasanto 16ba4e8
Fix promise
coreymasanto ad8a9a0
Syntax fix
coreymasanto 455d45e
Allow the XHR request to be sent if the inline video is unexpectedly …
coreymasanto 4b3a02f
Lint
coreymasanto 73c67c1
Remove unnecessary variable from shouldUseInlineVideoResponse and upd…
coreymasanto c92c2e7
Wrap JSON.parse() in a try/catch
coreymasanto 6164988
Pull out a new requestCachedVideoSources() method from the fetchCache…
coreymasanto 7c760e0
Clean up preexisting lengthy if-statement
coreymasanto b4093ea
Merge branch 'main' into inlinedVideo
coreymasanto 5640b66
Simplify JSON parsing logic in requestCachedVideoSources
coreymasanto 8787143
Add a check for the 'sources' key
coreymasanto d2465cc
Lint fix
coreymasanto bc73828
Add initial, untested version of tests for inline video response logic
coreymasanto 697dd6b
Merge branch 'main' into inlinedVideo
coreymasanto b477b97
Add a describe grouping for the set of inline video response tests
coreymasanto 2d108a6
Update logic for determining whether the inline response should be used
coreymasanto a5487d2
Get tests passing
coreymasanto c328d21
Lint fixes
coreymasanto e0e6de7
Merge branch 'main' into inlinedVideo
coreymasanto e0e8b85
Merge branch 'main' into inlinedVideo
coreymasanto d4ed4ec
Merge branch 'main' into inlinedVideo
coreymasanto db458ea
Merge branch 'main' into inlinedVideo
coreymasanto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.