Skip to content

✨added camelCase to amp-story-shoppping component #37533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
processprocess merged 4 commits into from
Feb 1, 2022
Merged

✨added camelCase to amp-story-shoppping component #37533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d74eaa
added camelCase
jshamble Feb 1, 2022
9efa362
fixed find and replace bugs
jshamble Feb 1, 2022
fc0605d
fixed find and replace bugs
jshamble Feb 1, 2022
dce556e
added correct class
jshamble Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 59 additions & 59 deletions examples/amp-story/amp-story-shopping.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,38 +48,38 @@
{
"items" : [
{
"product-id": "lamp",
"product-title": "Brass Lamp",
"product-brand": "Lamp Co",
"product-price": 799.00,
"product-price-currency": "USD",
"product-images": ["https://source.unsplash.com/Ry9WBo3qmoc/500x500"]
"productId": "lamp",
"productTitle": "Brass Lamp",
"productBrand": "Lamp Co",
"productPrice": 799.00,
"productPriceCurrency": "USD",
"productImages": ["https://source.unsplash.com/Ry9WBo3qmoc/500x500"]
},
{
"product-id": "art",
"product-title": "Abstract Art",
"product-brand": "V. Artsy",
"product-price": 1200.00,
"product-price-currency": "INR",
"product-images": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
"productId": "art",
"productTitle": "Abstract Art",
"productBrand": "V. Artsy",
"productPrice": 1200.00,
"productPriceCurrency": "INR",
"productImages": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
},
{
"product-id": "chair",
"product-title": "Yellow chair",
"product-brand": "Chair Co.",
"product-price": 1000.00,
"product-price-currency": "BRL",
"product-tag-text": "The perfectly imperfect yellow chair",
"product-images": ["https://source.unsplash.com/DgQGKKLaVhY/500x500"]
"productId": "chair",
"productTitle": "Yellow chair",
"productBrand": "Chair Co.",
"productPrice": 1000.00,
"productPriceCurrency": "BRL",
"productTagText": "The perfectly imperfect yellow chair",
"productImages": ["https://source.unsplash.com/DgQGKKLaVhY/500x500"]
},
{
"product-id": "flowers",
"product-title": "Flowers",
"product-brand": "Very Long Flower Company Name",
"product-price": 10.00,
"product-price-currency": "USD",
"product-icon": "/examples/visual-tests/amp-story/img/shopping/icon.png",
"product-images": ["https://source.unsplash.com/SavQfLRm4Do/500x500"]
"productId": "flowers",
"productTitle": "Flowers",
"productBrand": "Very Long Flower Company Name",
"productPrice": 10.00,
"productPriceCurrency": "USD",
"productIcon": "/examples/visual-tests/amp-story/img/shopping/icon.png",
"productImages": ["https://source.unsplash.com/SavQfLRm4Do/500x500"]
}
]
}
Expand All @@ -105,12 +105,12 @@
{
"items" : [
{
"product-id": "art",
"product-title": "Abstract Art",
"product-brand": "V. Artsy",
"product-price": 1200.00,
"product-price-currency": "JPY",
"product-images": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
"productId": "art",
"productTitle": "Abstract Art",
"productBrand": "V. Artsy",
"productPrice": 1200.00,
"productPriceCurrency": "JPY",
"productImages": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
},
]
}
Expand Down Expand Up @@ -154,39 +154,39 @@
{
"items" : [
{
"product-id": "lamp-rtl",
"product-title": "Brass Lamp",
"product-brand": "Lamp Co",
"product-price": 799.00,
"product-price-currency": "AED",
"product-tag-text": " حبا حبا حبا سعادةا سعادة",
"product-images": ["https://source.unsplash.com/Ry9WBo3qmoc/500x500"]
"productId": "lamp-rtl",
"productTitle": "Brass Lamp",
"productBrand": "Lamp Co",
"productPrice": 799.00,
"productPriceCurrency": "AED",
"productTagText": " حبا حبا حبا سعادةا سعادة",
"productImages": ["https://source.unsplash.com/Ry9WBo3qmoc/500x500"]
},
{
"product-id": "art-rtl",
"product-title": "Abstract Art",
"product-brand": "V. Artsy",
"product-price-currency": "AED",
"product-price": 1200.00,
"product-tag-text": "حبا حب سعادة قط حبا حب سعادة قط ",
"product-images": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
"productId": "art-rtl",
"productTitle": "Abstract Art",
"productBrand": "V. Artsy",
"productPriceCurrency": "AED",
"productPrice": 1200.00,
"productTagText": "حبا حب سعادة قط حبا حب سعادة قط ",
"productImages": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
},
{
"product-id": "chair-rtl",
"product-title": "Yellow chair",
"product-brand": "Chair Co.",
"product-price": 1000.00,
"product-price-currency": "AED",
"product-images": ["https://source.unsplash.com/DgQGKKLaVhY/500x500"]
"productId": "chair-rtl",
"productTitle": "Yellow chair",
"productBrand": "Chair Co.",
"productPrice": 1000.00,
"productPriceCurrency": "AED",
"productImages": ["https://source.unsplash.com/DgQGKKLaVhY/500x500"]
},
{
"product-id": "flowers-rtl",
"product-title": "Flowers",
"product-brand": "Very Long Flower Company Name",
"product-price": 10.00,
"product-price-currency": "AED",
"product-icon": "/examples/visual-tests/amp-story/img/shopping/icon.png",
"product-images": ["https://source.unsplash.com/SavQfLRm4Do/500x500"]
"productId": "flowers-rtl",
"productTitle": "Flowers",
"productBrand": "Very Long Flower Company Name",
"productPrice": 10.00,
"productPriceCurrency": "AED",
"productIcon": "/examples/visual-tests/amp-story/img/shopping/icon.png",
"productImages": ["https://source.unsplash.com/SavQfLRm4Do/500x500"]
}
]
}
Expand Down
12 changes: 6 additions & 6 deletions examples/amp-story/shopping/remote.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"items": [
{
"product-id": "art",
"product-title": "Abstract Art",
"product-brand": "V. Artsy",
"product-price": 1200.0,
"product-price-currency": "JPY",
"product-images": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
"productId": "art",
"productTitle": "Abstract Art",
"productBrand": "V. Artsy",
"productPrice": 1200.0,
"productPriceCurrency": "JPY",
"productImages": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
}
]
}
120 changes: 60 additions & 60 deletions examples/visual-tests/amp-story/amp-story-shopping-lang-de.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,38 +49,38 @@
{
"items" : [
{
"product-id": "lamp",
"product-title": "Brass Lamp",
"product-brand": "Lamp Co",
"product-price": 799.00,
"product-price-currency": "USD",
"product-images": ["https://source.unsplash.com/Ry9WBo3qmoc/500x500"]
"productId": "lamp",
"productTitle": "Brass Lamp",
"productBrand": "Lamp Co",
"productPrice": 799.00,
"productPriceCurrency": "USD",
"productImages": ["https://source.unsplash.com/Ry9WBo3qmoc/500x500"]
},
{
"product-id": "art",
"product-title": "Abstract Art",
"product-brand": "V. Artsy",
"product-price": 1200.00,
"product-price-currency": "INR",
"product-images": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
"productId": "art",
"productTitle": "Abstract Art",
"productBrand": "V. Artsy",
"productPrice": 1200.00,
"productPriceCurrency": "INR",
"productImages": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
},
{
"product-id": "chair",
"product-title": "Yellow chair",
"product-brand": "Chair Co.",
"product-price": 1000.00,
"product-price-currency": "BRL",
"product-tag-text": "The perfectly imperfect yellow chair",
"product-images": ["https://source.unsplash.com/DgQGKKLaVhY/500x500"]
"productId": "chair",
"productTitle": "Yellow chair",
"productBrand": "Chair Co.",
"productPrice": 1000.00,
"productPriceCurrency": "BRL",
"productTagText": "The perfectly imperfect yellow chair",
"productImages": ["https://source.unsplash.com/DgQGKKLaVhY/500x500"]
},
{
"product-id": "flowers",
"product-title": "Flowers",
"product-brand": "Very Long Flower Company Name",
"product-price": 10.00,
"product-price-currency": "USD",
"product-icon": "/examples/visual-tests/amp-story/img/shopping/icon.png",
"product-images": ["https://source.unsplash.com/SavQfLRm4Do/500x500"]
"productId": "flowers",
"productTitle": "Flowers",
"productBrand": "Very Long Flower Company Name",
"productPrice": 10.00,
"productPriceCurrency": "USD",
"productIcon": "/examples/visual-tests/amp-story/img/shopping/icon.png",
"productImages": ["https://source.unsplash.com/SavQfLRm4Do/500x500"]
}
]
}
Expand All @@ -106,12 +106,12 @@
{
"items" : [
{
"product-id": "art",
"product-title": "Abstract Art",
"product-brand": "V. Artsy",
"product-price": 1200.00,
"product-price-currency": "JPY",
"product-images": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
"productId": "art",
"productTitle": "Abstract Art",
"productBrand": "V. Artsy",
"productPrice": 1200.00,
"productPriceCurrency": "JPY",
"productImages": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
},
]
}
Expand Down Expand Up @@ -155,40 +155,40 @@
{
"items" : [
{
"product-id": "lamp-rtl",
"product-title": "Brass Lamp",
"product-brand": "Lamp Co",
"product-price": 799.00,
"product-price-currency": "AED",
"product-tag-text": " حبا حبا حبا سعادةا سعادة",
"product-images": ["https://source.unsplash.com/Ry9WBo3qmoc/500x500"]
"productId": "lamp-rtl",
"productTitle": "Brass Lamp",
"productBrand": "Lamp Co",
"productPrice": 799.00,
"productPriceCurrency": "AED",
"productTagText": " حبا حبا حبا سعادةا سعادة",
"productImages": ["https://source.unsplash.com/Ry9WBo3qmoc/500x500"]
},
{
"product-id": "art-rtl",
"product-title": "Abstract Art",
"product-brand": "V. Artsy",
"product-price-currency": "AED",
"product-price": 1200.00,
"product-tag-text": "حبا حب سعادة قط حبا حب سعادة قط ",
"product-images": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
"productId": "art-rtl",
"productTitle": "Abstract Art",
"productBrand": "V. Artsy",
"productPriceCurrency": "AED",
"productPrice": 1200.00,
"productTagText": "حبا حب سعادة قط حبا حب سعادة قط ",
"productImages": ["https://source.unsplash.com/BdVQU-NDtA8/500x500"]
},
{
"product-id": "chair-rtl",
"product-title": "Yellow chair",
"product-brand": "Chair Co.",
"product-price": 1000.00,
"product-price-currency": "AED",
"product-icon": "/examples/visual-tests/amp-story/img/shopping/nest-home-icon.png",
"product-images": ["https://source.unsplash.com/DgQGKKLaVhY/500x500"]
"productId": "chair-rtl",
"productTitle": "Yellow chair",
"productBrand": "Chair Co.",
"productPrice": 1000.00,
"productPriceCurrency": "AED",
"productIcon": "/examples/visual-tests/amp-story/img/shopping/nest-home-icon.png",
"productImages": ["https://source.unsplash.com/DgQGKKLaVhY/500x500"]
},
{
"product-id": "flowers-rtl",
"product-title": "Flowers",
"product-brand": "Very Long Flower Company Name",
"product-price": 10.00,
"product-price-currency": "AED",
"product-icon": "/examples/visual-tests/amp-story/img/shopping/icon.png",
"product-images": ["https://source.unsplash.com/SavQfLRm4Do/500x500"]
"productId": "flowers-rtl",
"productTitle": "Flowers",
"productBrand": "Very Long Flower Company Name",
"productPrice": 10.00,
"productPriceCurrency": "AED",
"productIcon": "/examples/visual-tests/amp-story/img/shopping/icon.png",
"productImages": ["https://source.unsplash.com/SavQfLRm4Do/500x500"]
}
]
}
Expand Down
Loading