Skip to content

🐛 amp-story-shopping Added correct margins for RTL mode #37568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jshamble merged 8 commits into from
Feb 10, 2022
Merged

🐛 amp-story-shopping Added correct margins for RTL mode #37568

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f3f40e6
Added correct margins for RTl mode
jshamble Feb 3, 2022
35d9f18
fixed shopping rtl ordering code
jshamble Feb 8, 2022
2790136
added margin inline start
jshamble Feb 9, 2022
2712830
optimized margin
jshamble Feb 9, 2022
efd1df7
added fix
jshamble Feb 9, 2022
1f2b443
fixed tag flip of rtl order
jshamble Feb 10, 2022
c7e7951
fixed rtl tap flip
jshamble Feb 10, 2022
598b514
fixed rtl tap flip
jshamble Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
optimized margin
  • Loading branch information
@jshamble
jshamble committed Feb 9, 2022
commit 2712830914fd75d5ae4b1e07ed132eda74541d47
2 changes: 1 addition & 1 deletion extensions/amp-story-shopping/0.1/amp-story-shopping-tag.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ amp-story-shopping-tag {
background-repeat: no-repeat !important;
background-position: center !important;
flex-shrink: 0 !important;
margin: 2px 4px 2px 2px !important;
margin-inline-start: 9px !important;
margin-inline-end: 4px !important;
}

.i-amphtml-amp-story-shopping-tag-pill-text {
Expand Down