Skip to content

✨ [video cache] Append captions track from cache response #37893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
processprocess merged 15 commits into from
Mar 23, 2022
Merged

✨ [video cache] Append captions track from cache response #37893

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
007d2b7
function and tests
processprocess Mar 17, 2022
321bbc9
null test
processprocess Mar 17, 2022
3966f32
comment
processprocess Mar 17, 2022
d891cc2
better test
processprocess Mar 17, 2022
3d78e43
remove only
processprocess Mar 17, 2022
a3468a5
lint
processprocess Mar 17, 2022
b7000b0
update url to src
processprocess Mar 21, 2022
1d0b0f3
add srclang
processprocess Mar 21, 2022
201e67f
set crossorigin
processprocess Mar 21, 2022
ed1eb36
Update tests.
processprocess Mar 21, 2022
b463d8b
ACAO header test
processprocess Mar 21, 2022
7ea1843
update api and tests
processprocess Mar 22, 2022
1b54405
update e2e test
processprocess Mar 22, 2022
4af5cbd
Merge branch 'main' into track
processprocess Mar 23, 2022
55cd4ba
Update test
processprocess Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add srclang
  • Loading branch information
@processprocess
processprocess committed Mar 21, 2022
commit 1d0b0f3be5f425c4e5e9348998364c5c4efc93f1
2 changes: 2 additions & 0 deletions extensions/amp-video/0.1/test/test-video-cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,7 @@ describes.realWin('amp-video cached-sources', {amp: true}, (env) => {
json: () =>
Promise.resolve({
'captions_src': 'captions_src_response.vtt',
'captions_srclang': 'en-us',
'sources': [
{'url': 'video.mp4', 'bitrate_kbps': 700, 'type': 'video/mp4'},
],
Expand All @@ -517,6 +518,7 @@ describes.realWin('amp-video cached-sources', {amp: true}, (env) => {
json: () =>
Promise.resolve({
'captions_src': 'captions_src_response.vtt',
'captions_srclang': 'en-us',
'sources': [
{'url': 'video.mp4', 'bitrate_kbps': 700, 'type': 'video/mp4'},
],
Expand Down
15 changes: 10 additions & 5 deletions extensions/amp-video/0.1/video-cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function fetchCachedSources(
.then((response) => {
applySourcesToVideo(videoEl, response['sources'], maxBitrate);
applyAudioInfoToVideo(videoEl, response['has_audio']);
applyCaptionsTrackToVideo(videoEl, response['captions_src']);
applyCaptionsTrackToVideo(videoEl, response);
})
.catch(() => {
// If cache fails, video should still load properly.
Expand Down Expand Up @@ -161,14 +161,19 @@ function applyAudioInfoToVideo(videoEl, hasAudio) {
* Appends captions track to video if captions url is defined and video
* element doesn't have a track child specified in the document.
* @param {!Element} videoEl
* @param {string|undefined} captionsUrl
* @param {!Object} response
*/
function applyCaptionsTrackToVideo(videoEl, captionsUrl) {
if (!captionsUrl || videoEl.querySelector('track')) {
function applyCaptionsTrackToVideo(videoEl, response) {
if (
!response['captions_src'] ||
!response['captions_srclang'] ||
videoEl.querySelector('track')
) {
return;
}
const trackEl = createElementWithAttributes(videoEl.ownerDocument, 'track', {
'src': captionsUrl,
'src': response['captions_src'],
'srclang': response['captions_srclang'],
'kind': 'captions',
});
videoEl.appendChild(trackEl);
Expand Down