Skip to content

🚀 [Story performance] Fix CLS caused from AMP runtime CSS showing story before amp-story.css #37990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mszylkowski merged 23 commits into from
Apr 1, 2022
Merged

🚀 [Story performance] Fix CLS caused from AMP runtime CSS showing story before amp-story.css #37990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6aabe91
Added tasts
mszylkowski Dec 21, 2021
dc1fa87
Undo
mszylkowski Dec 21, 2021
d707e5b
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Dec 28, 2021
0e3df75
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Dec 28, 2021
a3f7bd0
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Jan 4, 2022
8c5119c
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Jan 6, 2022
77f8435
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Jan 10, 2022
16e712e
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Jan 19, 2022
8088eb7
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Jan 25, 2022
3858b2a
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Jan 28, 2022
e12d2f6
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Jan 31, 2022
2a29105
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Feb 1, 2022
a5b781f
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Feb 10, 2022
b8006ee
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Mar 8, 2022
b570e86
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Mar 10, 2022
6b7e456
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Mar 22, 2022
50bdff8
Merge branch 'ampproject:main' into main
mszylkowski Mar 24, 2022
267ae0e
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Mar 29, 2022
c7edd8c
Merge branch 'main' of github.com:mszylkowski/amphtml
mszylkowski Mar 29, 2022
9842a23
Merge branch 'main' of github.com:ampproject/amphtml
mszylkowski Mar 29, 2022
012947a
Added renderblocking CSS
mszylkowski Mar 31, 2022
19e80ff
Added reference to PR number
mszylkowski Mar 31, 2022
3d243c5
Merge branch 'main' of github.com:ampproject/amphtml into clsFromRunt…
mszylkowski Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions css/ampshared.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,11 @@ amp-analytics, amp-story-auto-ads, amp-auto-ads {
visibility: hidden;
}

/* Blocked rendering until amp-story.css is installed. Info on #37990. */
amp-story {
visibility: hidden !important;
}

html.i-amphtml-fie > amp-analytics {
/* Remove position fixed if it's in iframe.
* So runtime can measure layoutBox correctly
Expand Down
3 changes: 3 additions & 0 deletions extensions/amp-story/1.0/amp-story.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ amp-story[standalone] {
max-width: initial !important;
min-height: initial !important;
min-width: initial !important;

/* Unblocks rendering when this CSS file is installed. Info on #37990. */
visibility: visible !important;
}

amp-story[standalone].amp-notbuilt {
Expand Down