Skip to content

🧪 Experiment: story auto advance and new cta button #38097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
powerivq merged 2 commits into from
Apr 16, 2022
Merged

🧪 Experiment: story auto advance and new cta button #38097

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50fd083
Experiment: story auto advance and new cta button
powerivq Apr 13, 2022
594e25b
Review comments
powerivq Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Review comments
  • Loading branch information
@powerivq
powerivq committed Apr 15, 2022
commit 594e25b8a24335b964c5b406dc84067af00f1787
12 changes: 2 additions & 10 deletions extensions/amp-story-page-attachment/0.1/amp-story-open-page-attachment.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,14 +164,10 @@
--i-amphtml-outlink-cta-text-color: white !important;
}

.i-amphtml-story-page-open-attachment-outlink[active] {
.i-amphtml-story-page-open-attachment-outlink[active]:not(.i-amphtml-story-page-open-attachment-outlink-no-animation-exp) {
animation: i-amphtml-tap-scale var(--i-amphtml-page-attachment-ui-animation-duration) var(--i-amphtml-page-attachment-ui-animation-delay) both !important;
}

.i-amphtml-story-page-open-attachment-outlink-no-animation-exp.i-amphtml-story-page-open-attachment-outlink-no-animation-exp[active] {
animation: none !important;
}

.i-amphtml-story-outlink-page-attachment-arrow {
display: block !important;
cursor: pointer !important;
Expand All @@ -180,14 +176,10 @@
filter: drop-shadow(0px 2px 6px rgba(0, 0, 0, 0.3)) !important;
}

.i-amphtml-story-page-open-attachment[active] .i-amphtml-story-outlink-page-attachment-arrow {
.i-amphtml-story-page-open-attachment[active]:not(.i-amphtml-story-page-open-attachment-outlink-no-animation-exp) .i-amphtml-story-outlink-page-attachment-arrow {
animation: i-amphtml-move-up-arrow var(--i-amphtml-page-attachment-ui-animation-duration) var(--i-amphtml-page-attachment-ui-animation-delay) both !important;
}

.i-amphtml-story-page-open-attachment.i-amphtml-story-page-open-attachment-outlink-no-animation-exp[active] .i-amphtml-story-outlink-page-attachment-arrow {
animation: none !important;
}

@keyframes i-amphtml-move-up-arrow {
0%, 100% {
opacity: 1;
Expand Down
4 changes: 3 additions & 1 deletion extensions/amp-story-page-attachment/0.1/amp-story-open-page-attachment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {computedStyle, setImportantStyles} from '#core/dom/style';
import {getWin} from '#core/window';

import {getExperimentBranch} from '#experiments';
import {StoryAdSegmentExp} from '#experiments/story-ad-progress-segment';

import {Services} from '#service';
import {LocalizedStringId_Enum} from '#service/localization/strings';
Expand Down Expand Up @@ -133,7 +134,8 @@ const renderOutlinkUI = (pageEl, attachmentEl) => {
const openImgAttr = attachmentEl.getAttribute('cta-image');

const noAnimation =
getExperimentBranch(getWin(pageEl), 'story-ad-auto-advance') == 'c';
getExperimentBranch(getWin(pageEl), 'story-ad-auto-advance') ==
StoryAdSegmentExp.AUTO_ADVANCE_NEW_CTA_NOT_ANIMATED;

return openLabelOrFallback(
pageEl,
Expand Down