Skip to content

✨ [AMP Story Paywall] Validator changes to launch amp-story-subscriptions #38194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ychsieh merged 8 commits into from
Jul 18, 2022
Merged

✨ [AMP Story Paywall] Validator changes to launch amp-story-subscriptions #38194

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
674b9da
amp-story-subscriptions doc
ychsieh May 10, 2022
d8e5c8f
merge
ychsieh May 13, 2022
de6cbb6
validator test
ychsieh May 13, 2022
6bda3b1
Merge branch 'main' into validator
ychsieh May 13, 2022
b768213
Merge branch 'main' into validator
ychsieh May 16, 2022
eb56fbc
Add optional attributes
ychsieh May 20, 2022
bcbe781
Merge branch 'main' into validator
ychsieh Jun 2, 2022
4b36752
Merge remote-tracking branch 'upstream/main' into validator
ychsieh Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add optional attributes
  • Loading branch information
@ychsieh
ychsieh committed May 20, 2022
commit eb56fbc472335615a88a21762d4794aae6163eb2
9 changes: 9 additions & 0 deletions extensions/amp-story-subscriptions/validator-amp-story-subscriptions.protoascii
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,13 @@ tags: { # <amp-story-subscriptions>
name: "description"
mandatory: true
}
Copy link
Copy Markdown
Contributor

@gmajoulet gmajoulet May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add the other supported fields as listed in your documentation, otherwise people can't use them: #38179

Copy link
Copy Markdown
Contributor Author

@ychsieh ychsieh May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the catch.

attrs: {
name: "subscriptions-page-index"
}
attrs: {
name: "headline"
}
attrs: {
name: "additional-description"
}
}