Skip to content

🚀 [Story localization] Removed localization strings from js #38280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mszylkowski merged 6 commits into from
Jun 9, 2022
Merged

🚀 [Story localization] Removed localization strings from js #38280

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0494704
Removed localization strings from js
mszylkowski Jun 8, 2022
8709337
Merge branch 'main' of github.com:ampproject/amphtml into remove_loca…
mszylkowski Jun 8, 2022
bba4baf
Call enabled experiment if there is performance service
mszylkowski Jun 8, 2022
8382175
Remove performance metric
mszylkowski Jun 8, 2022
510b7c7
Fix shopping attachment test
mszylkowski Jun 8, 2022
95f6f2e
Fixed tests
mszylkowski Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 1 addition & 57 deletions extensions/amp-story/1.0/amp-story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,32 +56,10 @@ import {StoryAdSegmentExp} from '#experiments/story-ad-progress-segment';

import {Services} from '#service';
import {calculateExtensionFileUrl} from '#service/extension-script';
import {createPseudoLocale} from '#service/localization/strings';

import {getDetail} from '#utils/event-helper';
import {dev, devAssert, user} from '#utils/log';

import LocalizedStringsAr from './_locales/ar.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsDe from './_locales/de.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsEnGb from './_locales/en-GB.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsEn from './_locales/en.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsEs419 from './_locales/es-419.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsEs from './_locales/es.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsFr from './_locales/fr.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsHi from './_locales/hi.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsId from './_locales/id.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsIt from './_locales/it.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsJa from './_locales/ja.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsKo from './_locales/ko.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsNl from './_locales/nl.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsNo from './_locales/no.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsPtBr from './_locales/pt-BR.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsPtPt from './_locales/pt-PT.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsRu from './_locales/ru.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsTr from './_locales/tr.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsVi from './_locales/vi.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsZhCn from './_locales/zh-CN.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import LocalizedStringsZhTw from './_locales/zh-TW.json' assert {type: 'json'}; // lgtm[js/syntax-error]
import {AmpStoryConsent} from './amp-story-consent';
import {AmpStoryEmbeddedComponent} from './amp-story-embedded-component';
import {AmpStoryGridLayer} from './amp-story-grid-layer';
Expand Down Expand Up @@ -2679,41 +2657,7 @@ export class AmpStory extends AMP.BaseElement {
if (this.maybeRegisterInlineLocalizationStrings_(storyLanguages[0])) {
return;
}
if (isExperimentOn(this.win, 'story-remote-localization')) {
this.fetchLocalizationStrings_(storyLanguages);
Services.performanceFor(this.win).addEnabledExperiment(
'story-remote-localization'
);
} else {
getLocalizationService(this.element).registerLocalizedStringBundles({
'default': LocalizedStringsEn,
'ar': LocalizedStringsAr,
'de': LocalizedStringsDe,
'en': LocalizedStringsEn,
'en-GB': LocalizedStringsEnGb,
'es': LocalizedStringsEs,
'es-419': LocalizedStringsEs419,
'fr': LocalizedStringsFr,
'hi': LocalizedStringsHi,
'id': LocalizedStringsId,
'it': LocalizedStringsIt,
'ja': LocalizedStringsJa,
'ko': LocalizedStringsKo,
'nl': LocalizedStringsNl,
'no': LocalizedStringsNo,
'pt-PT': LocalizedStringsPtPt,
'pt-BR': LocalizedStringsPtBr,
'ru': LocalizedStringsRu,
'tr': LocalizedStringsTr,
'vi': LocalizedStringsVi,
'zh-CN': LocalizedStringsZhCn,
'zh-TW': LocalizedStringsZhTw,
'en-xa': createPseudoLocale(
LocalizedStringsEn,
(s) => `[${s} one two]`
),
});
}
this.fetchLocalizationStrings_(storyLanguages);
}

/**
Expand Down